Bug 197172 - nic_get_links() doesn't correctly handle multipart netlink replies (xenguest-install failure)
Summary: nic_get_links() doesn't correctly handle multipart netlink replies (xenguest-...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libdhcp
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Vas Dias
QA Contact:
URL:
Whiteboard:
: 196739 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-06-29 01:47 UTC by Mark McLoughlin
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-11 20:26:53 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
libdhcp-1.5-multipart-nlmsgs.patch (1.20 KB, patch)
2006-06-29 01:47 UTC, Mark McLoughlin
no flags Details | Diff

Description Mark McLoughlin 2006-06-29 01:47:56 UTC
Problem occurs using xenguest-install.py on x86_64.

Basically, DHCP fails in anaconda/loader2 because libdhcp claims not to know
anything about eth0.

The error messages are:

         INFO    : sending dhcp request through device eth0
         DEBUG   : waiting for link eth0...
         DEBUG   :    5 seconds.
         WARNING :     no network link detected on eth0
         ERROR   : nic_by_name: no interface named eth0 found
         CRITICAL: dhcp_nic: net_get_by_name(eth0) failed
         DEBUG   : dhcp: DHCP configuration failed

The problem is that nic_get_links() doesn't find eth0 in the first bunch of
nlmsgs returned from nl_recv() ... we need to keep reading messages until we get
 a NLMSG_DONE.

It seems to crop up here only because eth0 is initialized after lo, vif0.[0-7],
veth[0-7], sit0 etc.

Attaching a rough patch that fixes it for me

Comment 1 Mark McLoughlin 2006-06-29 01:47:56 UTC
Created attachment 131707 [details]
libdhcp-1.5-multipart-nlmsgs.patch

Comment 2 Heath Petty 2006-07-06 18:54:37 UTC
This problem also affects i386. Applying this patched fixed the issue for me.

Comment 3 David Cantrell 2006-07-11 20:26:53 UTC
Patch applied to CVS, will be in libdhcp-1.7.  Thanks.

Comment 4 Jeremy Katz 2006-07-20 21:57:50 UTC
*** Bug 196739 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.