Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-curve25519-dalek.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-curve25519-dalek-3.1.0-1.fc35.src.rpm Description: Pure-Rust implementation of group operations on ristretto255 and Curve25519. Fedora Account System Username: eclipseo
New Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-curve25519-dalek.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-curve25519-dalek-3.1.0-1.fc35.src.rpm
I assume: %if %{__cargo_skip_build} BuildArch: noarchspe %endif ^^^ is a typo. LICENSE and src headers in https://github.com/dalek-cryptography/curve25519-dalek/tree/3.1.0 looks correct as BSD. No surprising divergences from vanilla rust2rpm spec file. Koji scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=73028583 does seems to build on all archs. Looks like dalek.rs 's webcert might have expired. Package is APPROVED
One please tweak: revisiting the cpufeatures review, I think should package can and should be enabled for all rust_arches?
Thanks for the review(! In reply to Jens Petersen from comment #3) > One please tweak: revisiting the cpufeatures review, > I think should package can and should be enabled for all rust_arches? The readme specifies that it is only working for aarch64 and x86_64: https://crates.io/crates/cpufeatures
I missed that.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-curve25519-dalek
(In reply to Jens Petersen from comment #3) > One please tweak: revisiting the cpufeatures review, > I think should package can and should be enabled for all rust_arches? Hi Jens, what do you mean here? cpufeatures is an aarch64 and x86_64 specific dependency, but it is also only a dependency on those architectures ... It should always be scoped to those two targets and not be a dependency otherwise, like here, in sha2: https://github.com/RustCrypto/hashes/blob/master/sha2/Cargo.toml#L24
I did a scratch build with all %{rust_arches}. https://koji.fedoraproject.org/koji/taskinfo?taskID=73652213 It all but armv7hl have finished and unit tests run with no errors as I write. I think there might be a misunderstanding about what cpufeatures means. Apparently, the library can use CPU features to accelerate operations - but only on the supported CPUs. The other arches work, but are slower. I believe now that you should use %{rust_arches}.
Several packages waiting on this. Eagerly looking for files to be imported.
Looks like Robert-André imported the version from Comment#1 without addressing any issues. I pushed a follow-up commit and builds to update the package to the latest version (3.1.0 -> 3.2.0) and fix the remaining issues ... So this is now in rawhide, f35, and f34, and I have dropped the buildroot overrides for the faulty 3.1.0 version and made ones for 3.2.0. Robert-André, if you're reading this, please add @rust-sig to this package (and your other Rust packages where you forgot to do this, for example, rust-cpufeatures). I already added it to anitya / release-monitoring and to koschei.
Sorry I must have missed it.