Bug 1984194 - Review Request: rust-pathsearch - Search for files in PATH
Summary: Review Request: rust-pathsearch - Search for files in PATH
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-20 22:56 UTC by Davide Cavalca
Modified: 2022-08-25 16:43 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-17 14:19:51 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2021-07-20 22:56:55 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-pathsearch/rust-pathsearch.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-pathsearch/rust-pathsearch-0.2.0-1.fc35.src.rpm

Description:
Search for files in PATH.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-07-20 22:56:57 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=72268179

Comment 2 Fabio Valentini 2022-04-30 09:44:19 UTC
Are you still interested in packaging this crate?
If yes, please refresh the packaging with rust2rpm 21.

Comment 4 Fabio Valentini 2022-08-17 09:33:37 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files (submitted PR and included upstream file)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Not sure why you're using the forge macros just to construct one source URL, but that's your choice.
Other than that, looks good to me.

Comment 5 Davide Cavalca 2022-08-17 11:21:35 UTC
Thanks!

$ fedpkg request-repo rust-pathsearch 1984194
https://pagure.io/releng/fedora-scm-requests/issue/46471
$ fedpkg request-branch --repo rust-pathsearch f37
https://pagure.io/releng/fedora-scm-requests/issue/46472
$ fedpkg request-branch --repo rust-pathsearch f36
https://pagure.io/releng/fedora-scm-requests/issue/46473
$ fedpkg request-branch --repo rust-pathsearch f35
https://pagure.io/releng/fedora-scm-requests/issue/46474

Comment 6 Gwyn Ciesla 2022-08-17 13:18:51 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pathsearch

Comment 7 Fedora Update System 2022-08-17 14:18:01 UTC
FEDORA-2022-911623a3b9 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-911623a3b9

Comment 8 Fedora Update System 2022-08-17 14:19:51 UTC
FEDORA-2022-911623a3b9 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2022-08-17 14:26:18 UTC
FEDORA-2022-9c5f794e2f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9c5f794e2f

Comment 10 Fedora Update System 2022-08-17 14:36:40 UTC
FEDORA-2022-edf0469a4a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-edf0469a4a

Comment 11 Fedora Update System 2022-08-17 14:37:52 UTC
FEDORA-2022-9c5f794e2f has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2022-08-17 14:46:52 UTC
FEDORA-2022-fb0c928d67 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-fb0c928d67

Comment 13 Fedora Update System 2022-08-18 02:55:29 UTC
FEDORA-2022-edf0469a4a has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-edf0469a4a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-edf0469a4a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-08-18 03:30:41 UTC
FEDORA-2022-fb0c928d67 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-fb0c928d67 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-fb0c928d67

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-08-25 16:17:55 UTC
FEDORA-2022-fb0c928d67 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2022-08-25 16:43:04 UTC
FEDORA-2022-edf0469a4a has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.