Bug 1985466 - `less` leaves terminal in mouse-reporting mode after exiting
Summary: `less` leaves terminal in mouse-reporting mode after exiting
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: less
Version: 33
Hardware: x86_64
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Matej Mužila
QA Contact: Fedora Extras Quality Assurance
URL: https://retrace.fedoraproject.org/faf...
Whiteboard: abrt_hash:6aac03edfeba8d97fbf03484e4b...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-07-23 15:59 UTC by Kamil Dudka
Modified: 2021-11-27 01:16 UTC (History)
10 users (show)

Fixed In Version: less-590-2.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1976410
Environment:
Last Closed: 2021-11-27 01:16:06 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Kamil Dudka 2021-07-23 15:59:46 UTC
As originally reported at bug #1976410 by Benno Schulenberg, the version of `less` that we have in Fedora 33+ leaves terminal in mouse-reporting mode after exiting, which results in crashes of the nano editor.

Could you please update less to a fixed version or backport the fix from upstream?

See the details below.

+++ This bug was initially created as a clone of Bug #1976410 +++

--- Additional comment from Benno Schulenberg on 2021-07-23 12:23:58 CEST ---

I have been wondering why we have seen so many crashes of nano since last January (https://retrace.fedoraproject.org/faf/reports/?component_names=nano&order_by=last_occurrence), and the other day I noticed the following line in the release notes of 'less': "Fix bug which could leave terminal in mouse-reporting mode after exiting less."  Leaving the terminal in mouse reporting mode might be the cause for ncurses getch() returning many ERR results while touching the mouse or the touchpad while using nano, causing the old 123 limit to be reached and thus causing nano to die.  That bug in less was introduced in version 551, which appeared in Fedora 33, and was fixed in version 590, which is not yet in Fedora.

Maybe it would be a good idea to pull in less-590 into Fedora 34, to avoid problems with mouse events in other terminal apps?  Or maybe just pull in the 21e0892e commit from less that fixes this issue?

Comment 1 Benno Schulenberg 2021-08-02 10:03:21 UTC
For precision: versions of 'less' before 590 /can/ leave the terminal in mouse-reporting mode [1]: only when the equivalent of --mouse is used; I don't think 'less' does this by default.  And I think that this mouse-reporting mode /could/ cause nano to crash (after having used 'less'), but I'm not sure, as I'm unable to reproduce the issue that is seen in the FAF reports.

[1] http://www.greenwoodsoftware.com/less/news.590.html

Comment 2 Ben Cotton 2021-11-04 13:49:17 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Ben Cotton 2021-11-04 14:18:40 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Ben Cotton 2021-11-04 15:16:25 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Fedora Update System 2021-11-11 13:25:31 UTC
FEDORA-2021-d6096058b7 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d6096058b7

Comment 6 Fedora Update System 2021-11-12 01:24:59 UTC
FEDORA-2021-d6096058b7 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-d6096058b7`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-d6096058b7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2021-11-27 01:16:06 UTC
FEDORA-2021-d6096058b7 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.