Bug 198605 - rpmlint looks in changelog for make-check-outside-check-section
Summary: rpmlint looks in changelog for make-check-outside-check-section
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rpmlint
Version: 5
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ville Skyttä
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-07-12 09:08 UTC by Paul Howarth
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version: 0.78-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-24 16:15:15 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Paul Howarth 2006-07-12 09:08:07 UTC
rpmlint looks for "make test" or "make check" outside the %check section of the
spec when checking SRPMs (make-check-outside-check-section). Unfortunately one
of the places it looks is in the changelog, so a changelog entry like this:

* Sat Jul 31 2004 Paul Howarth <paul> 1.20-1
- Update to 1.20
- Moved `make test' into %%check section
- General tidy up of spec file

results in:

W: perl-Mail-Mbox-MessageParser make-check-outside-check-section - Moved `make
test' into %%check section

Comment 1 Ville Skyttä 2006-07-12 14:49:52 UTC
I haven't tested it myself, but I think this was fixed a couple of days ago in
upstream svn:  http://rpmlint.zarb.org/cgi-bin/trac.cgi/changeset/1245

Could you try it out and let me know if it works for you?

Hm, skimming the patch tells me that we should probably also skip the test in
%description sections.

Comment 2 Paul Howarth 2006-07-12 15:42:56 UTC
The patch worked for me. I agree about the %description sections but I think
it's much less likely to be a problem there.

Comment 3 Ville Skyttä 2006-09-24 16:15:15 UTC
Fixed in 0.78-1.


Note You need to log in before you can comment on or make changes to this bug.