Bug 198653 - xf86writeConfigFile always writes Files and Module sections
Summary: xf86writeConfigFile always writes Files and Module sections
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: xorg-x11-server
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: X/OpenGL Maintenance List
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-07-12 15:12 UTC by Chris Lumens
Modified: 2007-11-30 22:11 UTC (History)
0 users

(edit)
Clone Of:
(edit)
Last Closed: 2006-07-21 20:49:26 UTC


Attachments (Terms of Use)
patch to not write out empty sections (821 bytes, patch)
2006-07-12 15:12 UTC, Chris Lumens
no flags Details | Diff

Description Chris Lumens 2006-07-12 15:12:04 UTC
The Files and Module sections are always written out, even if they are empty,
because the printers in xc/programs/Xserver/hw/xfree86/parser/write.c do not
have guards to check for NULL.  Other sections in the config file writer have
these guards.  Attached is a simple, but untested, patch against the gitweb sources.

Comment 1 Chris Lumens 2006-07-12 15:12:04 UTC
Created attachment 132311 [details]
patch to not write out empty sections

Comment 2 Mike A. Harris 2006-07-21 20:49:26 UTC
Patch added to: xorg-x11-server-1.1.1-7


Note You need to log in before you can comment on or make changes to this bug.