This service will be undergoing maintenance at 00:00 UTC, 2016-08-01. It is expected to last about 1 hours
Bug 198816 - Review Request: gfs-utils - global file system userland utilities
Review Request: gfs-utils - global file system userland utilities
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ruben Kerkhof
Fedora Package Reviews List
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2006-07-13 16:20 EDT by Chris Feist
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-04-04 17:15:31 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Chris Feist 2006-07-13 16:20:40 EDT
Spec URL: http://people.redhat.com/cfeist/gfs-utils.spec
SRPM URL: http://people.redhat.com/cfeist/gfs-utils-0.1.0-0.fc6.0.src.rpm
Description: This package provides the userland utilities for GFS (Global File System) version 1.  mkfs, fsck, etc.
Comment 1 Ralf Corsepius 2006-07-14 04:16:02 EDT
You spec contains this:

if ["$1" = 0 ]; then

This is invalid /bin/sh syntax. There must be a blank after the '['.
Comment 3 Parag AN(पराग) 2006-07-15 02:53:46 EDT
Mock build failed for rawhide i386
main.c:29:26: error: libvolume_id.h: No such file or directory

You Need to add libvolume_id-devel in BuildRequires

Comment 4 Chris Feist 2006-07-17 15:12:22 EDT
Fixed that as well. (libvolume_id.h BuildRequire)

New files are here:
http://people.redhat.com/cfeist/gfs-utils.spec
http://people.redhat.com/cfeist/gfs-utils-0.1.0-0.fc6.2.src.rpm
Comment 5 Jason Tibbitts 2006-07-20 22:47:58 EDT
Chris, I don't see you in the cvsextras group.  Do you require sponsorship?  See
http://fedoraproject.org/wiki/Extras/HowToGetSponsored for more information.
Comment 6 Chris Feist 2006-09-29 16:14:02 EDT
Jason,

Yes I do need sponsorship for this package.  Can you sponsor me?
Comment 7 Jason Tibbitts 2006-09-29 18:01:23 EDT
I can, but would need to look over this and your other submissions first.  I
hope to have some time to spend on extras reviews over the next couple of days.
Comment 8 Ruben Kerkhof 2007-01-22 18:11:47 EST
Hi Chris,

Since you've been sponsored by jkatz, I'll remove the FE-NEEDSPONSOR blocker.

I've found a few things though:

rpmlint of gfs-utils is not silent:
W: gfs-utils incoherent-version-in-changelog 0.1.0-0.fc6.0 0.1.0-0.fc6.2
W: gfs-utils service-default-enabled /etc/rc.d/init.d/gfs
E: gfs-utils missing-mandatory-lsb-tag Description
E: gfs-utils missing-mandatory-lsb-tag Short-Description
W: gfs-utils incoherent-init-script-name gfs

The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)

Scriptlets: missing "service" in %preun (wiki: ScriptletSnippets)
Scriptlets: missing "service" in %postun (wiki: ScriptletSnippets)

* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* No downloadable source. Please give the full URL in the Source tag.

Please don't hardcode the distro in Release, use %dist
Comment 9 Ruben Kerkhof 2007-02-03 16:29:39 EST
Ping?
Comment 10 Chris Feist 2007-02-21 16:51:35 EST
I've updated the package.  I don't know what 'missing-mandatory-lsb-tag' means
and can't find any documentation on how to fix those errors.  All other errors
should be fixed.  There is no central location for the gfs-utils-0.1.11.tar.gz
script, it's pulled directly out of cvs which is found at
sources.redhat.com/cluster/

http://people.redhat.com/cfeist/gfs-utils-0.1.11-3.src.rpm

Let me know what else I need for this rpm.
Comment 11 Ruben Kerkhof 2007-02-21 18:19:02 EST
Thanks Chris,

> E: gfs-utils missing-mandatory-lsb-tag Description
> E: gfs-utils missing-mandatory-lsb-tag Short-Description

Those errors are about the init file
rpmlint checks that file for tags between

### BEGIN INIT INFO

and 

### END INIT INFO

The checks are defined in /usr/share/rpmlint/InitScriptCheck.py

A few new rpmlint warnings have popped up:

[ruben@odin i386]$ rpmlint gfs-utils-0.1.11-3.i386.rpm 
W: gfs-utils dangling-relative-symlink /sbin/mount.gfs mount.gfs2
W: gfs-utils dangling-relative-symlink /sbin/umount.gfs umount.gfs2

[ruben@odin i386]$ rpmlint gfs-utils-debuginfo-0.1.11-3.i386.rpm 
W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/log.c
W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/fs_dir.c
W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/util.c
W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/inode.c
W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/fs_bits.c
W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/rgrp.c
W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/file.c
W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/fs_bmap.c
W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/bitmap.c
W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/fs_inode.c
W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/block_list.c
W: gfs-utils-debuginfo spurious-executable-perm /usr/src/debug/gfs-0.1.11/libgfs/bio.c
Comment 12 Ruben Kerkhof 2007-03-23 04:07:05 EDT
Hi Chris,

Please respond, or I'll have to close this ticket in a week.
Comment 13 Ruben Kerkhof 2007-04-04 17:15:31 EDT
Sorry, I'll have to close this review.

Note You need to log in before you can comment on or make changes to this bug.