Bug 1990052 - Define tests, including gating tests, for virt-p2v
Summary: Define tests, including gating tests, for virt-p2v
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: virt-p2v
Version: 9.1
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: beta
: ---
Assignee: Richard W.M. Jones
QA Contact: Xiaodai Wang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-04 16:14 UTC by Beraldo Leal
Modified: 2022-11-15 11:46 UTC (History)
10 users (show)

Fixed In Version: virt-p2v-1.42.2-1.1.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-15 10:39:16 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-92355 0 None None None 2021-08-04 16:18:34 UTC
Red Hat Product Errata RHBA-2022:8228 0 None None None 2022-11-15 10:39:18 UTC

Description Beraldo Leal 2021-08-04 16:14:20 UTC
Goal: 

 * Define tests, including gating tests, for virt-p2v

Additional Information:

Some components have tests defined in RHEL8 but those tests are not present in RHEL9

The definition must include both gating and non-gating tests.

The suggested approach to resolving this BZ is:

  1) check if this component is still present in RHEL9;

 * [http://file.rdu.redhat.com/~asamalik/content-set/rhel8-vs-rhel9-components.html]

  2) check if there are already any test case for this individual component on RHEL9;

  3) If not, check if the test is present in RHEL8 and copy `gating.yaml` file and `tests directory` to RHEL9 repo;
 * [https://gitlab.com/redhat/centos-stream/rpms/virt-p2v]

4) If not present, create some tests (including gating) for this component.

Please work closely with QE (but keep in mind that they might be busy with the mass migration) or any other team that is maintaining those tests. The test definitions in `gating.yaml` describe test jobs that run in a CI environment. The test jobs and/or the testing environment may need to be modified to work in RHEL-9, or perhaps brand new test jobs may need to be created.

For more information watch [Alexandra's presentation|https://drive.google.com/file/d/1p9OAfUIbYONFQJeRoX9FoCf-0X-FnHVl/view] on this topic (after min 13).

If you have any questions here, please ask me or @yash.

Comment 1 Klaus Heinrich Kiwi 2021-08-24 18:19:08 UTC
Any updates here?

Comment 2 Richard W.M. Jones 2021-08-24 20:00:58 UTC
virt-p2v isn't a package as such in RHEL.  It's an ISO.  From RHEL 9
we decided that it was so troublesome to get EXD to make this package
that we'd just distribute it ourselves from the upstream site.
However I haven't built it yet.

As such we don't care much about gating tests, but also I want to
keep this bug around because we may need the virt-p2v package in
RHEL (or may not, unclear).

Comment 5 Richard W.M. Jones 2021-09-01 08:41:19 UTC
As a general rule of thumb, unless a bug is so serious
that it causes something to completely fail, we should
move any RHEL 9 Beta bug to RHEL 9.

In this case it's a gating test, and for a package that
we don't really ship yet (we will eventually ship it
separately from RHN), so I've moved it to RHEL 9.

Comment 7 Richard W.M. Jones 2022-01-12 16:03:50 UTC
Moving to 9.1 because we're still not in a position to release virt-p2v
in RHEL 9.

Comment 9 Richard W.M. Jones 2022-05-19 07:46:03 UTC
Putting this on the backlog.

We don't need virt-p2v in RHEL 9 right at the moment, because we're
building and shipping the package ourselves.  But once we switch to
using Image Builder (which requires some other work to be done first)
we'll use this package again.  We can worry about gating tests then.

Comment 10 Laszlo Ersek 2022-05-27 07:26:55 UTC
We've made progress on bug 2038105, but we haven't decided on the delivery method yet. Marking this one as "Devel Cond-NAK: Design" for the time being.

(BTW, "docs/p2v-hacking.pod" names a local test that I think is non-interactive, and therefore could be used as a gating test:

$ make run-virt-p2v-non-gui-conversion
)

Comment 11 Richard W.M. Jones 2022-05-27 07:54:12 UTC
FYI here is the gating test used for virt-v2v (mainly to show how this gating
test thing is done):

https://gitlab.com/redhat/centos-stream/rpms/virt-v2v/-/blob/c9s/gating.yaml
https://gitlab.com/redhat/centos-stream/rpms/virt-v2v/-/tree/c9s/tests

(Yes, it uses its own dialect of yaml.  No, they told us they won't fix that)

I think the bigger problem here (and a good reason to defer fixing this for
now) is that we don't have a good understanding of what the packaging
of virt-p2v needs to look like in RHEL.  Will we have a "virt-p2v" package at all?
Should it have a different name?  If so, will it be in BuildRoot or CRB?  How will
we stop customers from trying to run it directly and point them at the ISO /
Image Builder?

All of these answers will change when we eventually switch to using Image Builder.

Comment 12 Klaus Heinrich Kiwi 2022-08-03 13:32:12 UTC
(In reply to Laszlo Ersek from comment #10)
> We've made progress on bug 2038105, but we haven't decided on the delivery
> method yet. Marking this one as "Devel Cond-NAK: Design" for the time being.
> 
> (BTW, "docs/p2v-hacking.pod" names a local test that I think is
> non-interactive, and therefore could be used as a gating test:
> 
> $ make run-virt-p2v-non-gui-conversion
> )

Hi Laszlo,

are we maybe closer to moving this out of our backlog and start planning around it?

Comment 19 Richard W.M. Jones 2022-08-03 16:42:01 UTC
Remove TestOnly temporarily for reasons.

Comment 20 Richard W.M. Jones 2022-08-03 16:51:01 UTC
Re-add TestOnly for reasons.

Comment 24 Richard W.M. Jones 2022-08-03 17:18:20 UTC
Drop TestOnly ... again.

Comment 30 Xiaodai Wang 2022-08-09 09:53:13 UTC
The gating result of this bug is PASS.
So move the bug to VERIFIED.

Comment 32 errata-xmlrpc 2022-11-15 10:39:16 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt-p2v bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:8228


Note You need to log in before you can comment on or make changes to this bug.