Red Hat Bugzilla – Bug 199381
PATCH: sparc sun drivers
Last modified: 2007-11-30 17:11:38 EST
Description of problem:
the attached patch adds the sun specific drivers to the xorg-x11-drivers
Version-Release number of selected component (if applicable):
Steps to Reproduce:
Created attachment 132658 [details]
The Requires in this package are automatically generated by a one liner
shell script present in a comment in the spec file, as that is the only
sane way to ensure the package is in sync with what the actual driver
packages are in the OS. When someone changes a driver, they are likely
to forget to update the drivers package, or to introduce inconsistencies,
so having it scriptable is a big advantage.
However, this approach unintentionally imposes a limit on which architectures
the package handles. The solution I've got in mind for this is to change
the script from listing one ifarch block per driver, to having one ifarch
block per arch, and having a number of Requires: lines in the single
block for the given driver.
That will serve 3 useful purposes:
- Allows us to autogenerate the architectures we build for.
- Allows us to include statically generated content in the spec for 3rd
party architectures such as sparc to supplement the autogenerated bits.
- Will make the spec file much smaller and neater looking.
Just need to write the script code that will spit out output of the form:
Requires: xorg-x11-drv-ati xorg-x11-drv-i810 ...
..., with each Requires line having a maximum of 4 drivers listed per line
for readability. I suspect a small perl script is the quickest and easiest
way to do this. Low priority right now, but I'll implement it at some point.
In the mean time, I can add a hack into the spec for sparc for now. Can
you rewrite the spec in the form:
%ifarch sparc sparc64
Requires: <all of the new drivers to add>
Also, you generated your patch backwards (args reversed).
Created attachment 136038 [details]
adds sparc drivers as requested
With secondary archs to come online soon. I will be submitting all the sun
drivers for review and then they will live in fedora cvs space. maybe that
Dennis, I've added you to the acl for xorg-x11-drivers. When you've got the sun
drivers in CVS, go ahead and add them to the drivers metapackage behind %ifarch.