Bug 1994912 - Review Request: rust-aliasable - Basic aliasable (non unique pointer) types
Summary: Review Request: rust-aliasable - Basic aliasable (non unique pointer) types
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-18 07:33 UTC by Christian Heimes
Modified: 2021-08-23 15:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-23 15:11:52 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Christian Heimes 2021-08-18 07:33:34 UTC
Spec URL: https://cheimes.fedorapeople.org/rust/rust-aliasable.spec
SRPM URL: https://cheimes.fedorapeople.org/rust/rust-aliasable-0.1.3-1.fc34.src.rpm
Description: Rust library providing basic aliasable (non core::ptr::Unique) types
Fedora Account System Username: cheimes

Comment 1 Christian Heimes 2021-08-18 07:34:18 UTC
Package is a dependency of rust-ouroboros 0.10, https://crates.io/crates/ouroboros/0.10.1/dependencies

Comment 2 Fabio Valentini 2021-08-20 16:55:55 UTC
Taking this review.

Looks like one of the optional dependencies is not available on Fedora yet:

Error: 
 Problem 1: conflicting requests
  - nothing provides (crate(aliasable_deref_trait/default) >= 0.2.0 with crate(aliasable_deref_trait/default) < 0.3.0~) needed by rust-aliasable+aliasable_deref_trait-devel-0.1.3-1.fc36.noarch
 Problem 2: conflicting requests
  - nothing provides (crate(aliasable_deref_trait/default) >= 0.2.0 with crate(aliasable_deref_trait/default) < 0.3.0~) needed by rust-aliasable+traits-devel-0.1.3-1.fc36.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

You'll need to either package aliasable_deref_trait 0.2.1, or drop this optional feature from rust-aliasable, if possible.

Comment 3 Christian Heimes 2021-08-23 06:50:35 UTC
I have re-created the spec and SRPM file without aliasable_deref_trait feature.

$ cat .rust2rpm.conf 
[DEFAULT]
unwanted-features = aliasable_deref_trait

Comment 4 Fabio Valentini 2021-08-23 10:04:31 UTC
This didn't work:

 Problem: conflicting requests
  - nothing provides (crate(aliasable_deref_trait/default) >= 0.2.0 with crate(aliasable_deref_trait/default) < 0.3.0~) needed by rust-aliasable+traits-devel-0.1.3-1.fc36.noarch

The "traits" feature depends on the optional "aliasable_deref_trait". You'll need to disable that feature as well.
I looked at the ouroboros code, and it looks like it doesn't use the "traits" feature of "aliasable", so that *should* be OK, but please confirm this yourself.

Comment 5 Christian Heimes 2021-08-23 10:25:10 UTC
I' have now dropped all traits related features from the spec file and uploaded the files again.

$ cat .rust2rpm.conf 
[DEFAULT]
unwanted-features =
  stable_deref_trait
  aliasable_deref_trait
  traits


$ mock -r fedora-rawhide-x86_64 --rebuild rust-aliasable-0.1.3-1.fc36.src.rpm --postinstall
...
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                                                                            1/1 
  Installing       : rust-aliasable-devel-0.1.3-1.fc36.noarch                                                                                                   1/3 
  Installing       : rust-aliasable+alloc-devel-0.1.3-1.fc36.noarch                                                                                             2/3 
  Installing       : rust-aliasable+default-devel-0.1.3-1.fc36.noarch                                                                                           3/3 
  Verifying        : rust-aliasable-devel-0.1.3-1.fc36.noarch                                                                                                   1/3 
  Verifying        : rust-aliasable+alloc-devel-0.1.3-1.fc36.noarch                                                                                             2/3 
  Verifying        : rust-aliasable+default-devel-0.1.3-1.fc36.noarch                                                                                           3/3 

Installed:
  rust-aliasable+alloc-devel-0.1.3-1.fc36.noarch         rust-aliasable+default-devel-0.1.3-1.fc36.noarch         rust-aliasable-devel-0.1.3-1.fc36.noarch        

Complete!
INFO: 
Finish: run

Comment 6 Fabio Valentini 2021-08-23 10:46:26 UTC
Yup, can confirm this works now.

Final review:

The package was  generated with rust2rpm, which simplifies the review.

- latest version is packaged
- package builds and installs correctly in rawhide
- specified license matches upstream
- license text is included and marked as %license
- test suite is run and all tests pass
- unavailable optional features / dependencies are disabled

Package APPROVED.

When importing this package to src.fedoraproject.org, please also include and commit the accompanying .rust2rpm.conf file such that future updates will inherit the dropped features / optional dependencies automatically.

Comment 7 Gwyn Ciesla 2021-08-23 13:55:03 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-aliasable

Comment 8 Fedora Update System 2021-08-23 14:32:54 UTC
FEDORA-2021-73cf2ac5f4 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2021-08-23 15:11:52 UTC
FEDORA-2021-89c90fca3b has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.