Bug 2001553
| Summary: | GtkShortcutsWindow doesn't visually distinguish shortcut keys for numeric keypad from the main keyboard | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | zhoujunqin <juzhou> | ||||
| Component: | gtk3 | Assignee: | Matthias Clasen <mclasen> | ||||
| Status: | CLOSED MIGRATED | QA Contact: | Desktop QE <desktop-qa-list> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 9.0 | CC: | berrange, otte, tpopela, tyan, tzheng, virt-maint, xiaodwan | ||||
| Target Milestone: | rc | Keywords: | MigratedToJIRA | ||||
| Target Release: | --- | Flags: | pm-rhel:
mirror+
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-09-15 16:53:45 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
The virt-viewer code registers multiple *different* shortcuts for the zoom actions, because the numeric keypad needs separate accelerator entries:
{ "zoom-in", "win.zoom-in", { "<Ctrl>plus", "<Ctrl>KP_Add", NULL } },
{ "zoom-out", "win.zoom-out", { "<Ctrl>minus", "<Ctrl>KP_Subtract", NULL } },
{ "zoom-reset", "win.zoom-reset", { "<Ctrl>0", "<Ctrl>KP_0", NULL } },
https://gitlab.com/virt-viewer/virt-viewer/-/blob/master/src/virt-viewer-app.c#L2426
The screenshot shown is from a stock GTK widget GtkShortcutsWindow which is populated from the UI definition at:
https://gitlab.com/virt-viewer/virt-viewer/-/blob/master/src/resources/ui/virt-viewer-shortcuts.ui
GTK's widget is not distinguishing between the regular plus/minus/0 keys and the same on the numeric keypad.
Either it needs to make them visually distinctive, or it should merge the two together when displaying the shortcuts.
Fwiw, in GTK4, we have code that adds 'KP' to the accel label for this case: https://gitlab.gnome.org/GNOME/gtk/-/commit/c58d9446f40b36136f25baf66dfb6116fb16888c That could easily be backported to GTK3. Upstream backport: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5176 Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug. This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there. Due to differences in account names between systems, some fields were not replicated. Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information. To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer. You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like: "Bugzilla Bug" = 1234567 In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information. |
Created attachment 1820823 [details] The screenshot for the shortcuts. Description of problem: The zoom actions have two sets of shortcuts in virt-viewer window. Version-Release number of selected component (if applicable): virt-viewer-10.0-3.el9.x86_64 libvirt-7.6.0-2.el9.x86_64 qemu-kvm-6.1.0-1.el9.x86_64 gtk-vnc2-1.2.0-3.el9.x86_64 How reproducible: 100% Steps to Reproduce: 1. Connect to VM's console via virt-viewer. $ virt-viewer -c qemu:///system $vm 2. Click the "Main app menu" ->select "Keyboard shortcuts"-> then the "Shortcuts" window pop up. Actual results: The zoom actions have two sets of shortcuts. Expected results: Only shows one set is enough. Additional info: