Spec URL: https://download.copr.fedorainfracloud.org/results/adamthiede/gemini/fedora-34-x86_64/02872416-amfora/amfora.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/adamthiede/gemini/fedora-34-x86_64/02872416-amfora/amfora-1.8.0-1.fc34.src.rpm Description: Fancy terminal browser for Gemini (new Internet protocol, like gopher) Fedora Account System Username: adamthiede This is my first package and I will require a sponsor. I am not the upstream maintainer but have permission/endorsement to package this for Fedora. I welcome and and all corrections or suggestions. A successful copr build lives here: https://copr.fedorainfracloud.org/coprs/adamthiede/gemini/build/2872416/ (minor edit, updated links to a slightly better build that had rawhide included.)
I know next to nothing about go packaging, but - this looks like a handwritten spec. Looking at other golang packages, most specs are based on the output of "go2rpm". Maybe try using that? > %global debug_package %{nil} This won't fly. We want debuginfo. https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/ > %if 0%{?suse_version} > BuildRequires: go > %endif Specs must be Fedora/RHEL only. No conditionals for other distros are allowed. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_legibility
Thank you for the advice and for taking a look at this. I will attempt to correct these. I was also not aware of go2rpm. Is that required if this is just a piece of software built with go, and not a library to be imported by other go packages? There are several other pieces of go software that amfora imports that are not yet packaged. I assume I'd have to get those packaged first? No matching package to install: 'golang(github.com/makeworld-the-better-one/go-gemini)' No matching package to install: 'golang(github.com/makeworld-the-better-one/go-isemoji)' No matching package to install: 'golang(github.com/mmcdole/gofeed)' No matching package to install: 'golang(github.com/rkoesters/xdg/basedir)' No matching package to install: 'golang(github.com/rkoesters/xdg/userdirs)' No matching package to install: 'golang(gitlab.com/tslocum/cview)'
> I was also not aware of go2rpm. Is that required if this is just a piece of software built with go, and not a library to be imported by other go packages? You're free to write a spec by hand. It's just that looking at other package reviews, almost all golang packages are based on go2rpm's output. > There are several other pieces of go software that amfora imports that are not yet packaged. I assume I'd have to get those packaged first? Yes. All the dependencies need to be packaged and submitted for review as well. Also, take a look at the Golang packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/
Based on your suggestion and how other go packages look I'm going to try and do this properly. I've begun to build some of the dependencies. The spec files are located at this repo https://github.com/elagost/golang-specfiles They are mostly building in this copr https://copr.fedorainfracloud.org/coprs/adamthiede/golang-specfiles/packages/ golang-code-rocketnine-tslocum-cview and golang-code-rocketnine-tslocum-cbind are giving me some trouble with paths - their generated spec files don't build and the output of go2rpm says > The forge provided is not known by go-rpm-macros. You will have to provide the source and archive parameters manually. but I think I'll have it figured out soon.
I got amfora successfully building. SRPM: https://download.copr.fedorainfracloud.org/results/adamthiede/golang-specfiles/fedora-34-x86_64/02882552-golang-github-makeworld-the-better-one-amfora/golang-github-makeworld-the-better-one-amfora-1.8.0-1.fc34.src.rpm Spec: https://download.copr.fedorainfracloud.org/results/adamthiede/golang-specfiles/fedora-34-x86_64/02882552-golang-github-makeworld-the-better-one-amfora/golang-github-makeworld-the-better-one-amfora.spec The other dependencies are also building here. https://copr.fedorainfracloud.org/coprs/adamthiede/golang-specfiles/builds/ I had to self-build golang-github-schollz-progressbar since the version in F34 and F35 isn't up to date enough (the version in Rawhide is). Still have yet to figure out the code-rocketnine dependencies, but since moving to the new git host the author hasn't made any updates, and I'd assume most packages still reference them at their former gitlab url, so I've built them from that as well.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.