Red Hat Bugzilla – Bug 201116
HELP NEEDED xchat version upgrade
Last modified: 2007-11-30 17:11:39 EST
xchat-2.6.0 is the current version in rawhide, but upstream is at 2.6.6.
Help is needed to port our patches to 2.6.6. Please attach an updated spec and
updated patches in this report.
Created attachment 133529 [details]
Spec file for 2.6.6
Created attachment 133530 [details]
Patch fixed for 2.6.6 #1
Created attachment 133531 [details]
Patch fixed for 2.6.6 #2
It might be worth including this patch for Finnish bugs:
Note that this choice you've made:
turns the input-box to a GtkTextView, and looks kind of ugly (it appears to be
1.5 lines height for some reason). Just thought I'd bring it to your attention.
Using --enable-spell=static might be better, unless there's some specific reason
you've chosen this.
If you use --enable-spell=static, you need enchant as a dependency, which is in
extras, not in core. That means xchat would need to be moved to extras, I think.
Building this into FC6 after test2 is out.
About Enchant, yes you're right, but it's a soft (run time) dependancy (i.e. it
uses dlopen() and fails without complaining). Ah well...
*** Bug 183449 has been marked as a duplicate of this bug. ***
From Bug 183449:
Comment #11 From Christopher Aillon (firstname.lastname@example.org) on 2006-08-04 15:40
We also really ought to get the multiline patch in.
There are also some patches proposed by RÃ©mi Collet there.
Warren, ping? Test2 is out, this is on the Target list, can we get this pushed out?
thanks for the reminder, I'll get an initial version in then others can suggest
Hmm... xchat-2.6.6 seems to be unusable with input methods. It is intercepting
or conflicting with ENTER on commit. I'd like to avoid pushing with this known
major regression. Digging a little deeper...
OK, if I build without --enable-spell=gtkspell it fixes input method commit.
Please suggest additional fixes to the package that hits rawhide tomorrow. I
will not re-enabled spell checking unless somebody finds a solution to that bug.
so, with 2.6.6 in rawhide, should we close this bug ?
Maybe the gtkspell problems should get looked at? It would be nice to have
spell checking (though I'm personally not a big fan of it because I use 4
different languages and hate having to toggle the spell checker all the time),
but of course not if it breaks stuff.
Created attachment 134612 [details]
xchat IM gtkspell fix
This patch may fix it, but the patch is untested and an unknown quantity. It
does use a "private" gtk field.
Note that using gtkspell is not the default, so fixing this isn't a big priority
upstream. Using --enable-spell=static may be the go, as it fixes the IM issue,
makes the input box look better (GtkEntry) and allows optional spelling if you
install libenchant (a soft run-time dependancy).
I'd rather not usea private GTK+ field because the underlying GTK+ could change,
and the gtkspell input text widget does make the client look uglier.
I didn't know static was an optional soft dependency. If this works fine, then
I suppose we could use static and allow users to optionally install libenchant.
--enable-spell=static will be enabled in tomorrow's rawhide. Please attach
further proposed fixes to this bug.
F7 and Rawhide have 2.6.6 now. And the next version upgrade (2.8.2) is already
in Rawhide and F7 updates-testing, see bug #224180.
Oh, and even FC6 has 2.6.6.