Bug 2017642 - [Tracker ACM] Enhance ACM must-gather to add collecting Ramen artifacts
Summary: [Tracker ACM] Enhance ACM must-gather to add collecting Ramen artifacts
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat OpenShift Data Foundation
Classification: Red Hat Storage
Component: must-gather
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: ODF 4.12.0
Assignee: yati padia
QA Contact: Shrivaibavi Raghaventhiran
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-10-27 05:30 UTC by yati padia
Modified: 2023-08-09 16:35 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-02-08 14:06:28 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github stolostron must-gather pull 117 0 None open remove shellcheck error 2022-09-15 10:29:22 UTC
Github stolostron must-gather pull 84 0 None Merged Collect Ramen Resources 2022-03-04 02:08:47 UTC
Github stolostron must-gather pull 86 0 None Merged must-gather: cleanup ramen resources 2022-03-04 16:25:14 UTC
Github stolostron must-gather pull 91 0 None Merged collect output for ramen resources 2022-04-05 14:25:01 UTC

Description yati padia 2021-10-27 05:30:49 UTC
Description of problem (please be detailed as possible and provide log
snippests):

Enhance ACM must-gather to add collecting Ramen artifacts

Additional Info:

Collect logs in must-gather for the following:
Hub cluster:
 * Odr-system namespace resources:
   - Secrets
   - ConfigMaps
   - Pod logs
 * DRPolicy object
 * MirrorPeers object
 * Application namespace resources on the hub:
  - Channel(s) used by the Subscription(s)
  - All Subscription(s)
  - All PlacementRule(s)
  - DRPlacementControl
 * ACM resources across managed cluster namespaces as per drClusterSet in DRPolicy:
   - ManifestWork
   - ManagedClusterView

Comment 4 Shrivaibavi Raghaventhiran 2022-02-23 16:39:11 UTC
Hi @ypadia

Comment 5 Shrivaibavi Raghaventhiran 2022-02-23 16:40:47 UTC
I dont find default Volumereplicationclass details in must-gather

I see the vr and vrgs for busybox workload in must-gather and not the default ones "odf-rbd-volumereplicationclass"

http://rhsqe-repo.lab.eng.blr.redhat.com/OCS/ocs-qe-bugs/bz-2057489/

Do we have VR details covered by this BZ or need a separate BZ ?

Comment 6 yati padia 2022-02-24 04:10:36 UTC
Hi,
The vr and vrgs are not covered in this bug. You can open a new bug with the details.

Comment 7 Mudit Agarwal 2022-03-01 14:09:42 UTC
Not a blocker, moving it out of 4.10 because of dev freeze

Comment 10 krishnaram Karthick 2022-03-02 06:49:59 UTC
(In reply to Mudit Agarwal from comment #7)
> Not a blocker, moving it out of 4.10 because of dev freeze

Mudit, I believe we would need this fix even if we are considering RDR would be a TP feature as we won't have ramen-related logs to analyze in case customers run into issues. Hence, we should consider this as a blocker IMO.

Comment 11 Mudit Agarwal 2022-03-02 07:12:43 UTC
Yes, we can fix it before 4.10 GA but it is not a dev freeze blocker. No code changes will be there in ODF code.
I will make sure that this gets in before 4.10 GA.

Comment 13 yati padia 2022-03-04 02:16:08 UTC
@srangana please check the https://github.com/stolostron/must-gather/pull/84 and let me know if you want anything else to be collected. Orelse we can move it on QA

Comment 17 yati padia 2022-03-08 13:12:15 UTC
yes, others are part of odf-must-gather.

Comment 18 yati padia 2022-03-08 13:12:29 UTC
yes, others are part of odf-must-gather.

Comment 19 Mudit Agarwal 2022-03-09 10:10:39 UTC
Bringing it back to 4.10 as the code is already merged in ACM

Comment 23 Shrivaibavi Raghaventhiran 2022-03-31 11:15:15 UTC
@ypadia Can you please add the fixed in version

Comment 24 yati padia 2022-03-31 11:56:21 UTC
Didn't get you. Do you mean a backport PR? And is that need to be done today?

Comment 25 yati padia 2022-03-31 11:56:50 UTC
Didn't get you. Do you mean a backport PR? And is that need to be done today?

Comment 26 yati padia 2022-03-31 11:56:59 UTC
Didn't get you. Do you mean a backport PR? And is that need to be done today?

Comment 27 Mudit Agarwal 2022-03-31 12:46:53 UTC
Shrivaibavi,

The fix is not there in ODF code, it is there in ACM.
It should be available with the latest ACM build.

Comment 28 Shrivaibavi Raghaventhiran 2022-04-01 12:36:05 UTC
Ran the Must-gather oc adm must-gather --image="quay.io/acm-d/acm-must-gather-rhel8:v2.5.0-18"

I dont see the below resources  
* ACM resources across managed cluster namespaces as per drClusterSet in DRPolicy:
   - ManifestWork
   - ManagedClusterView

Also it would be good to have mirrorpeer description. 

@yati Please confirm my observation

ACM MG here : http://rhsqe-repo.lab.eng.blr.redhat.com/OCS/ocs-qe-bugs/MG_ACM/

Comment 29 yati padia 2022-04-01 13:10:07 UTC
yes, these resources need to be added too. I will make another PR for it.

Comment 30 Shrivaibavi Raghaventhiran 2022-04-04 08:07:41 UTC
Moving the BZ back to Assigned state considering comment #28 and #29

Comment 31 Mudit Agarwal 2022-04-05 13:50:46 UTC
Not a 4.10 blocker, moving it out

Comment 35 yati padia 2022-04-05 14:27:08 UTC
The PR is merged now and the bug can be verified now.

Comment 42 yati padia 2022-09-21 08:24:27 UTC
@sraghave can you please reverify this.

Comment 43 Shrivaibavi Raghaventhiran 2022-11-08 13:23:39 UTC
Ramen Resources are being collected in ACM MG logs. Hence moving this to Verified

Logs: http://rhsqe-repo.lab.eng.blr.redhat.com/OCS/ocs-qe-bugs/bz-ramen/


Note You need to log in before you can comment on or make changes to this bug.