Bug 2017942 - Reconsider "Explicitly force optimization level 2 and debuginfo for release builds"
Summary: Reconsider "Explicitly force optimization level 2 and debuginfo for release b...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: cmake
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Björn 'besser82' Esser
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-10-27 18:41 UTC by Michael Catanzaro
Modified: 2021-10-28 18:57 UTC (History)
5 users (show)

Fixed In Version: cmake-3.22.0-0.3.rc2.fc36
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-10-28 18:57:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Michael Catanzaro 2021-10-27 18:41:04 UTC
Hi, I think we should reconsider the change "Explicitly force optimization level 2 and debuginfo for release builds." See:

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/O3G7HNM45FXRQ4TTIHJKAKQPB7U4VR2E/

and specifically the discussion following:

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/NRQADKKIH5YWYK6IUIU3LBVYHEY33Z77/

I wonder, was it intended for CMAKE_*_RELEASE_FLAGS to override %optflags?

Comment 1 Rex Dieter 2021-10-28 02:26:48 UTC
I agree the recent change probably ought to be reverted... 

I'm open to be convinced otherwise if some justification can be provided.

Comment 2 Fedora Update System 2021-10-28 09:36:21 UTC
FEDORA-2021-8f165f3a4e has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8f165f3a4e

Comment 3 Fedora Update System 2021-10-28 09:55:22 UTC
FEDORA-2021-8f165f3a4e has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 4 Michael Catanzaro 2021-10-28 15:49:30 UTC
You left the -g in the Fortran flags. Accident?

Comment 5 Björn 'besser82' Esser 2021-10-28 16:38:02 UTC
(In reply to Michael Catanzaro from comment #4)
> You left the -g in the Fortran flags. Accident?

Yes, it was an accident.  Fix is on it's way together with cmake-3.22.0-rc2.

Thank you for your attention!


Note You need to log in before you can comment on or make changes to this bug.