This bug has been migrated to another issue tracking site. It has been closed here and may no longer be being monitored.

If you would like to get updates for this issue, or to participate in it, you may do so at Red Hat Issue Tracker .
Bug 2020253 - [UI] New NAD is not reflected in Create plan/Create mapping wizards in case it has been added while the wizard was open
Summary: [UI] New NAD is not reflected in Create plan/Create mapping wizards in case i...
Keywords:
Status: CLOSED MIGRATED
Alias: None
Product: Migration Toolkit for Virtualization
Classification: Red Hat
Component: User Experience
Version: 2.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: Future
Assignee: Yaacov Zamir
QA Contact: Maayan Hadasi
Avital Pinnick
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-11-04 13:11 UTC by Maayan Hadasi
Modified: 2023-01-12 08:47 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-03 09:10:05 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker   MTV-457 0 None None None 2023-01-12 08:47:15 UTC

Description Maayan Hadasi 2021-11-04 13:11:45 UTC 
Description of problem:
New NAD is not reflected in Create plan/Create mapping wizards in case it has been added while the wizard was open. 
It shows up after restarting the wizard

The issue was found when added a NAD using CLI:
cat << EOF | oc apply -f -
---
apiVersion: "k8s.cni.cncf.io/v1"
kind: NetworkAttachmentDefinition
metadata:
  name: ovn-secondnetwork
  namespace: openshift-mtv
spec:
  config: '{
      "cniVersion": "0.3.1",
      "type": "cnv-bridge",
      "bridge": "br1"
    }'
EOF
 


Version-Release number of selected component (if applicable):
MTV 2.2.0-72 / iib:131251


How reproducible:
100%


Steps to Reproduce:
1. Open Create plan OR Create mapping wizard in MTV UI
2. Create a new NAD (example above)
3. Look for the new NAD in the target networks list 


Actual results:
The new NAD is not displayed. Need to restart the wizard
Comment 1 Mike Turley 2021-11-04 15:55:54 UTC 
Polling was deliberately disabled on the mapping steps of the wizard to prevent state breaking if the user has selected mapping items that get changed/deleted in the providers. We could re-enable this polling but we need to determine what to do if a source or target network is deleted while the user has it selected.

The simplest solution would be to simply remove that selection. In the case of source resources being deleted, those mapping rows would simply disappear. In the case of target resources, those selections would revert to the default.

@vconzola is that an acceptable UX? @fdupont do we want to try and fix this today / for 2.2? I don't imagine it's a blocker.
Comment 2 Mike Turley 2021-11-04 16:53:02 UTC 
Moving to 2.3 after discussing the above with Vince.
Comment 3 vconzola 2021-11-05 13:19:29 UTC 
As discussed with @mturley we'll reintroduce polling to address the main issue of the BZ and add warnings in the UI if the list of resource changes (i.e., networks are deleted) while in the plan wizard.
Comment 4 Mike Turley 2022-01-13 19:49:04 UTC 
Moving to 2.4 because we don't have time to address the risk of re-enabling polling in this wizard step before freeze.
Comment 5 Arik 2023-01-02 15:16:10 UTC 
Kobi, see comment 3 and comment 4 above - I understand that we used to poll resources while the dialog was open once and it was disabled later on, and the idea was to re-enable it to solve this issue.
In other products like RHV it's quite common that wizards are not reloaded with new entities that are added while the wizard is open but I don't know about Openshift - is it something that we can get "for free" by being a plugin of the OCP console? if it's not trivial, I wouldn't prioritize this
Comment 6 Yaacov Zamir 2023-01-03 08:31:41 UTC 
> Openshift - is it something that we can get "for free" by being a plugin of the OCP console?

Openshift console use "watch" by default ( instead of "get" ) so native Openshift components will update automatically

AFAIK we still use the legacy plan wizard that use "get", so this will not be fixed "for free" in 2.4, @rszwajko pleas keep me honest here.
we do plan to refactor all modals with native Openshift implementation, where we will use Openshifts "watch", but we will not have time in 2.4 time-frame.

@ahadas hi, IMHO we can move this issue to 2.4.1 because we plan to fix it as part of a bigger refactor effort to use native Openshift components in the modal,
( in 2.4.0 we will re-implement only the lists views ).

cc:// rszwajko , sdickers
Comment 7 Arik 2023-01-03 09:09:13 UTC 
Ack, thanks Kobi
So let's move it to Jira then
Note You need to log in before you can comment on or make changes to this bug.