Spec URL: https://pagure.io/phonesim/raw/main/f/phonesim.spec SRPM URL: https://pagure.io/phonesim/raw/main/f/phonesim-1.21-1.fc35.src.rpm Description: phonesim is a soft modem that eliminates the need to have an actual AT modem connected to the system for testing and developing Ofono. Fedora Account System Username: thunderbirdtr Pagure URL : https://pagure.io/phonesim
> %configure > %{__make} %{?_smp_mflags} 1. Using macro forms of system executables (%{__make}, %{__rm}, etc.) is discouraged. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros 2. "%make_build" is preferred for building. > %files > %{_datarootdir}/%{name}/default.xml This will make the package own the "/usr/share/phonesim/default.xml" file, but not the "/usr/share/phonesim" directory. https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ Also, the license file is not included in the package. Add "%license COPYING" under %files.
I believe this can now be abandoned as it is part of ofono and no longer used by the Plasma Mobile stack.
There were recently released version 2.0 [1]. This package might need version update or closing the review bug. Please close this review is you do not want to include this package anymore. Is it still useful to be included? [1] https://git.kernel.org/pub/scm/network/ofono/phonesim.git/tag/?h=2.0
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.