Created attachment 1841993 [details] Create button enabled Description of problem: ------------------------- When user tried to create Namespace store ,bucket class and backing store via UI and the required fields don't have an input , user is able to proceed ahead as "create " button is enabled and an error is encountered after the user clicks on create button (screenshot for same is attached ) Version-Release number of selected component: ------------------------------------------------ OCP : 4.9.0-0.nightly-2021-11-12-222121 ODF : 4.9.0-237.ci How reproducible: -------------------- Every time Steps to Reproduce: --------------------- 1. After the OCP cluster creation install ODF operator . 2. Create storage system . 3. Direct to storage--> ODF --> backing store and click in create backing store. 4. Leave one of the required fields empty and click on create. Actual results: --------------------- (1) Create button is enabled . (2) When click on create button , redirects to the next page and an error is encountered which says " Oops, something went wrong ". (3)When directed to storage --> ODF --> backing store , the BS created in previous step is present in dashboard but the status mentioned is "Rejected". Expected results: ----------------------- The create button should be either disabled or user should not be directed to the next page . Additional info: --------------------- Same is encountered with namespace store and bucket class.
*** Bug 2024547 has been marked as a duplicate of this bug. ***
We expect the validation to come from the Operator. There is already a validation framework setup this needs to be leveraged.
Not a 4.9 blocker
Operator needs to check whether the requested Object(CR) has enough information to proceed with CR creation. Something like an admission controller(https://kubernetes.io/blog/2019/03/21/a-guide-to-kubernetes-admission-controllers/) If this is done then UI can just propagate the error sent by the API to the user.
We always propagate the errors sent by the API. We have been doing this for all resources. Moving it to MCG.
HI Validated the fix with following builds:- OCP : 4.10.0-0.nightly-2022-02-26-230022 ODF : 4.10.0-169 **Observations : (a) For namespace store , even when all the required fields are not filled with user input, the user can still click on create button and it starts the creation . Later the status is shown as "creating' for long. (b) The Bucket class is fixed. (c) For Backing store again the creation is proceeded even if input for all required fields are not present . Screenshots are present here 'https://docs.google.com/document/d/1ET2NGIeedSg-g06EeMt3_txdkatC3ZDJ74TO5epoIuU/edit?usp=sharing' Since the fix is only available for Bucket class , re-assigning the bug . Thanks Mugdha
Retested the fix with following versions : OCP:- 4.10.0-0.nightly-2022-03-19-230512 ODF :- 4.10.0-198 When the target bucket was left empty and create button was clicked there was an error message displayed "admission webhook "admissionwebhook.noobaa.io" denied the request: Failed creating the Backingstore, please provide target bucket" and creation was not successful. Screenshot for same is attached in comment#21 and comment#22 . Moving the bug to verified state . Thanks and Regards Mugdha Soni