Bug 203646 - PATCH: fix googleearth (and other apps) slowness on r300 driver using cards.
Summary: PATCH: fix googleearth (and other apps) slowness on r300 driver using cards.
Alias: None
Product: Fedora
Classification: Fedora
Component: mesa   
(Show other bugs)
Version: rawhide
Hardware: All Linux
Target Milestone: ---
Assignee: Adam Jackson
QA Contact:
Depends On:
TreeView+ depends on / blocked
Reported: 2006-08-22 20:24 UTC by Hans de Goede
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-08-22 22:20:59 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
PATCH fixing the described problems (584 bytes, patch)
2006-08-22 20:24 UTC, Hans de Goede
no flags Details | Diff
Improved version of the patch (722 bytes, patch)
2006-09-01 20:10 UTC, Hans de Goede
no flags Details | Diff

Description Hans de Goede 2006-08-22 20:24:41 UTC
The attached patch comments this 1 line in r300_renderer.c:
FALLBACK_IF(ctx->Line.SmoothFlag); // GL_LINE_SMOOTH

the result of this is that if an application has requested anti-aliased lines,
which currently are not implemented in the r300 driver, the application gets
normal (not antialiased) lines instead of falling back to the software renderer.

This patch is needed to make googleearth and smc (http://www.secretmaryo.org/)
usable IMHO having none antialiased lines is way better then 2 fps.

The same could be argued for anti-aliased points (the line below this one), but
I haven't encountered any apps using this one yet.

Notice that this change was suggested by upstream and that upstream has even
concidered doing this themselves, they haven't however because they are planning
to fix this by actually implementing antialiased lines soon. In the mean time
however this is way way beter then 2 fps (or something around that speed).

Comment 1 Hans de Goede 2006-08-22 20:24:45 UTC
Created attachment 134669 [details]
PATCH fixing the described problems

Comment 2 Adam Jackson 2006-08-22 22:20:59 UTC
Ack!  Totally forgot about merging this.  Added in 6.5-25.*, thanks!

Comment 3 Hans de Goede 2006-08-23 04:03:07 UTC

I just wanted to say you rock! Now I (and hopefully lots of others) can enjoy
good working opensource hw accel 3D out of the box, yeah!

Comment 4 Hans de Goede 2006-09-01 20:10:34 UTC
Created attachment 135409 [details]
Improved version of the patch

As I was already afraid that would happen I've just encountered my first 2 apps
using GL_POINT_SMOOTH, causing once again 2-4 fps speeds. This is an updated
version of the patch adding the same workaround for points (iow draw them
aliased instead of SLOOOWWWWW) as the previous revision did for lines only.

Please replace the patch with this one, thanks!

Note You need to log in before you can comment on or make changes to this bug.