Bug 2056243 - Review Request: maui-mauikit-accounts - MauiKit utilities to handle User Accounts
Summary: Review Request: maui-mauikit-accounts - MauiKit utilities to handle User Acc...
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-02-20 12:43 UTC by Onuralp SEZER
Modified: 2023-09-28 00:41 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-09-28 00:41:16 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Onuralp SEZER 2022-02-20 12:43:25 UTC
Spec URL: https://pagure.io/Maukit-Packages/raw/main/f/mauikit-accounts/mauikit-accounts.spec

SRPM URL: https://pagure.io/Maukit-Packages/raw/main/f/mauikit-accounts/maui-mauikit-accounts-2.1.1-1.fc37.src.rpm

Description: MauiKit utilities to handle User Accounts
Fedora Account System Username: thunderbirdtr

Comment 1 Justin Zobel 2022-03-15 01:14:27 UTC
Need fixing:
- Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: mauikit-accounts.spec should be maui-mauikit-accounts.spec See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming
- /usr/lib64/qt5/qml/org/mauikit/accounts/qmldir.license in the main package isn't marked as a %license file

Licenses all good.

Comment 2 Troy Dawson 2022-10-14 15:56:03 UTC
- After discussion on KDE-SIG, this is being renamed to mauikit-accounts, so the spec file has the correct name, it's the source rpm that has the wrong name.
As was also discussed, the name change can happen when the package is requested.

- The latest version is also version 2.0.0.  Updating to that needs to be in concert with mauikit and mauikit-filebrowsing.

- This also uses %define instead of %global.  Is there a reason for this?

- The final problem is a hidden license file.

I think the following, added to your %prep section will fix the problem.

  mv src/controls/qmldir.license LICENSES/


At the very least, fix that license issue and I'll approve this.  But if you could fix the others while you are at it that would be great.

Comment 3 Justin Zobel 2023-09-28 00:41:16 UTC
I think this can be closed and if Onuralp wants to resurrect it at a later date, they can.


Note You need to log in before you can comment on or make changes to this bug.