Spec URL: http://student.agh.edu.pl/~grabka/acerhk/acerhk.spec SRPM URL: http://student.agh.edu.pl/~grabka/acerhk/acerhk.spec Description: This package contains the driver for managing special buttons and wireless antenna on Acer and compatible laptops.
I'm not a reviewer, but I can do what I can to help. rpmlint on both the binary (for i686 at least) and SRPMS comes out clean, and they build flawlessly on my machine. I have no complaints here, you have a pretty clean package!
Need to be added since kernel 2.6.18-1.2200.fc5, because like many kmod-package - including of linux/config.h now is deprecated. (i've pick a recent example from Ville Skyttä) %prep Setup ... grep -rlF '<linux/config.h>' acerhk-%{version} \ | xargs sed -i -e 's|<linux/config.h>|<linux/autoconf.h>|' Any idea when this package will be accepted on extras?
Same note as for the acerhk-kmod submission: Marcin: Do you still wish to submit this package? If I don't hear anything from you in 1 week I will go ahead and close it. NOTE: from what I can see on the upstream page, this driver is no longer being maintained... "Unfortunately I have not the time anymore to actively support this driver, I even don't own an Acer laptop anymore. If anyone is interested to take over the job of maintaining this driver, please contact me. You can still mail me, I will try to help you, but it will take some time and I am not always able to give help." (from: http://www.cakey.de/acerhk/)
Marcin: I am going to go ahead and close this now. If you want to continue, feel free to re-open this review or file a new one.