Bug 2078909 - aarch64 branch-protection test because the -mbranch-protection option was not used [NEEDINFO]
Summary: aarch64 branch-protection test because the -mbranch-protection option was not...
Keywords:
Status: MODIFIED
Alias: None
Product: Fedora
Classification: Fedora
Component: annobin
Version: 37
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nick Clifton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-04-26 13:21 UTC by Mark Wielaard
Modified: 2022-08-09 13:42 UTC (History)
7 users (show)

Fixed In Version: annobin-10.72-1.fc37
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:
nickc: needinfo? (dcantrell)


Attachments (Terms of Use)

Description Mark Wielaard 2022-04-26 13:21:01 UTC
https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/96557/testReport/(root)/tests/_annocheck/

Reports various aarch64 only issues:
FAIL: branch-protection test because the -mbranch-protection option was not used

But looking at the build.log the build definitely uses -mbranch-protection=standard

https://kojipkgs.fedoraproject.org//packages/elfutils/0.187/1.fc37/data/logs/aarch64/build.log

Comment 1 Nick Clifton 2022-04-26 16:24:20 UTC
This has been fixed by the 10.66 update to annobin.  (And a similar problem related to GO binaries and AArch64 has been fixed by the 10.67 update).

I am in the process of guiding an apprentice through the procedure of creating a Bodhi update request, so these new builds should reach the buildroot in the next few days.

Comment 2 Nick Clifton 2022-05-03 10:59:46 UTC
Annobin 10.67 is now in the rawhide buildroot, and 10.66 in the F36 buildroot.  So this problem should now be resolved.

Comment 3 Pavel Filipensky 2022-05-06 11:36:28 UTC
I am still facing this with rawhide.

https://kojipkgs.fedoraproject.org//packages/samba/4.16.1/0.fc37/data/logs/aarch64/root.log
  annobin-plugin-gcc          aarch64  10.67-1.fc37

https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/98397/testReport/(root)/tests/_annocheck/
  Hardened: /usr/bin/smbtorture: FAIL: branch-protection test because not enabled (function: test_free_wrapper_fd_handler)

Comment 5 Nick Clifton 2022-05-16 15:10:28 UTC
*sigh*.  It seems that the gcc plugin does not detect the -mbranch-protection option at all.  So I have disabled the FAIL message in annocheck.  The test should still work however since it also checks the notes in the .note.gnu.property section, which are used to enable/disable branch protection.

Fixed in annobin-10.72-1.fc37

Comment 6 Mark Wielaard 2022-05-26 12:17:28 UTC
Just did a valgrind build for f35, f36 and rawhide and they all still get flagged even though the build.log shows the binaries being build with -mbranch-protection=standard

https://bodhi.fedoraproject.org/updates/FEDORA-2022-933069cfdd (fc37)
https://bodhi.fedoraproject.org/updates/FEDORA-2022-35fc4f5632 (fc36)
https://bodhi.fedoraproject.org/updates/FEDORA-2022-9e02608a2f (fc35)

Comment 7 Nick Clifton 2022-05-27 10:56:25 UTC
(In reply to Mark Wielaard from comment #6)
> Just did a valgrind build for f35, f36 and rawhide and they all still get
> flagged even though the build.log shows the binaries being build with
> -mbranch-protection=standard
> 
> https://bodhi.fedoraproject.org/updates/FEDORA-2022-933069cfdd (fc37)
 
Digging into this - the issue is that rpminspect is still running annocheck version 10.70 rather than 10.72 (or newer).

I am not sure how/when rpminspect updates the packages that it uses.  
Annobin 10.73 is now in the stable releases for rawhide, f36 and f35, so all it should take is a 'dnf update' to get the tests to pass.

Comment 9 Ben Cotton 2022-08-09 13:42:04 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle.
Changing version to 37.


Note You need to log in before you can comment on or make changes to this bug.