Bug 208004 - Review Request: perl-Test-Perl-Critic - Use Perl::Critic in test programs
Summary: Review Request: perl-Test-Perl-Critic - Use Perl::Critic in test programs
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-09-25 19:43 UTC by Jose Pedro Oliveira
Modified: 2010-07-26 22:25 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-26 20:49:32 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Jose Pedro Oliveira 2006-09-25 19:43:42 UTC
Spec URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-Test-Perl-Critic.spec
SRPM URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-Test-Perl-Critic-0.07-1.src.rpm

Description:
Test::Perl::Critic wraps the Perl::Critic engine in a convenient
subroutine suitable for test programs written using the Test::More
framework. This makes it easy to integrate coding-standards enforcement
into the build process. For ultimate convenience (at the expense of some
flexibility), see the criticism pragma.

Comment 1 Jason Tibbitts 2006-09-26 01:02:57 UTC
* source files match upstream:
   91c1dc234b4c6ec1f06300085f0559cf  Test-Perl-Critic-0.07.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Test::Perl::Critic) = 0.07
   perl-Test-Perl-Critic = 0.07-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(English)
   perl(File::Spec)
   perl(Perl::Critic)
   perl(Perl::Critic::Utils)
   perl(Test::Builder)
   perl(strict)
   perl(warnings)
* %check is present and all tests pass:
   All tests successful.
   Files=7, Tests=14,  3 wallclock secs ( 3.09 cusr +  0.39 csys =  3.48 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 2 Jose Pedro Oliveira 2006-09-26 20:49:32 UTC
Thanks for the review.

Imported and built for FC-5 and devel.

jpo

Comment 3 Mark Chappell 2010-07-26 07:24:37 UTC
Package Change Request
======================
Package Name: perl-Test-Perl-Critic
New Branches: EL-6
Owners: tremble rmyers

See https://bugzilla.redhat.com/show_bug.cgi?id=617789

Comment 4 Kevin Fenzi 2010-07-26 22:25:09 UTC
CVS done (by process-cvs-requests.py).


Note You need to log in before you can comment on or make changes to this bug.