Spec URL: https://fuller.fedorapeople.org/golang-github-mbrt-gmailctl.spec SRPM URL: https://fuller.fedorapeople.org/golang-github-mbrt-gmailctl-0.10.4-1.fc36.src.rpm Description: Declarative configuration for Gmail filters Fedora Account System Username: fuller
Spec is correct, but before approving it two questions: - Wouldn't it better to call package directly `gmailctl` rather than `golang-github-mbrt-gmailctl`? If you want so, define the following global: %global goname gmailctl Rename the spec to gmailctl.spec and change this BZ's title. You can check `doctl` as an example. - You defined all the BuildRequires rather than using `%go_generate_buildrequires`. In some of your other specs you're using that macro, maybe you want to change this spec to use dynamic BuildRequires?
Thanks for the suggestions and for the review Re: BuildRequires, I had thought when I made up the spec that I was getting an error about a name mismatch when generating the requirements automatically - that isn't happening anymore. Updated files: Spec URL: https://fuller.fedorapeople.org/gmailctl.spec SRPM URL: https://fuller.fedorapeople.org/gmailctl-0.10.4-1.fc36.src.rpm
go2rpm package, fedora-review is correct: - The specfile is sane - License is correct - Builds successfully in mock - No rpmlint errors - %check section passes - The latest version is packaged - The package complies with the Packaging Guidelines Package approved! On import, don't forget to do the following: - Add package to release-monitoring.org - Add package to Koschei. - Give go-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID) Thanks!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gmailctl