Hi, About a week ago I've packaged mirrormagic, which is from the same author as rocksndiamonds. Since highscore saving didn't work in mirrormagic I took a look at how the rocksndiamonds package fixes this. However the rocksndiamonds package doesn't fix it. As currently packaged rocksndiamonds wants to save its highscores to /var/games/rocksndiamonds, however this dir is 755 root root, thus rocksndiamonds cannot write to it. Due to the way rocksndiamonds saves it highscores, save sgid games usage also is not an option, this I've decided to patch rocksndiamonds so that the highscores get saved on a per user basis to ~/.rocksndiamonds. While not ideal this is better then no highscore saving at all. The attached rocksndiamonds-3.2.2-highscore.patch, does this. Notice that in order for this to work you must add " -DUSE_USERDATADIR_FOR_COMMONDATA" to the EXTRA_CFLAGS arguments to make. The patch is written in this way for upstream merging. When this patch is applied the spec file should no longer create let alone add to %files the /var/games/rocksndiamonds dir. --- When packaging magicmirror I also did 2 other improvements to it, which also apply pretty much one on one to rocksndiamonds: * rocksndiamonds-3.2.2-yesno.patch Allow the user to answer yes/no questions (like the one asked when quiting) with the 'Y' and 'N' keys in addition to Enter / ESC. * rocksndiamonds-3.2.2-fstoggle.patch Allow the user to change from fullscreen to windowed mode and vica versa at any time by pressing alt+enter Let me know if you want these 2 additional patches in a seperate bug. I've send all 3 of them upstream too.
Created attachment 138508 [details] Patch fixing highscore saving
Created attachment 138509 [details] PATCH allow Y and N as answer to yes/no questions
Created attachment 138510 [details] PATCH: make alt+enter toggle fullscreen/windowed
Hi, I've send these upstream and upstream likes and will apply both the highscore and yesno patch, the fullscreen toggle patch isn't necessary as it turns out that rocksndiamonds already has that capability since 3.2.2 . I can push out an update of rocksndiamonds with the other 2 patches applied if you're short on time.
Tom, as already reported the 2 patches which I would like to see added to the FE rocksndiamonds package have been accepted by upstream. I esp. would like to see the highscore saving fixed. Is it ok if I add these 2 patches to FE CVS and request a build for this?
Sorry for the delay in applying these patches, when CVS came back up today, I committed and built new packages.