This bug has been migrated to another issue tracking site. It has been closed here and may no longer be being monitored.

If you would like to get updates for this issue, or to participate in it, you may do so at Red Hat Issue Tracker .
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2115976 - [RFE] use cgroup-v2 hierarchy to set memory limits for insights-client.service [NEEDINFO]
Summary: [RFE] use cgroup-v2 hierarchy to set memory limits for insights-client.service
Keywords:
Status: CLOSED MIGRATED
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: insights-client
Version: 9.0
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: CSI Client Tools Bugs
QA Contact: Red Hat subscription-manager QE Team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-05 21:18 UTC by Micah Abbott
Modified: 2023-09-07 13:12 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-09-07 13:12:27 UTC
Type: Story
Target Upstream Version:
Embargoed:
gchamoul: needinfo? (cmarinea)
ahitacat: needinfo? (cmarinea)


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker   RHEL-2484 0 None Migrated None 2023-09-07 13:09:57 UTC
Red Hat Issue Tracker RHELPLAN-130423 0 None None None 2022-08-05 21:19:09 UTC

Description Micah Abbott 2022-08-05 21:18:36 UTC
On the RHEL9 Edge VM with `insights-client-3.1.7-6.el9_0.noarch` installed, the `insights-client.service` is trying to set memory limits in the ExecStartPost of the service using the cgroup-v1 hierarchy.

```
$ sudo systemctl cat insights-client.service 
# /usr/lib/systemd/system/insights-client.service
# This file is part of insights-client.
#
# Any changes made to this file will be overwritten during a software update. To
# override a parameter in this file, create a drop-in file, typically located at
# /etc/systemd/system/insights-client.service.d/override.conf. Put the desired
# overrides in that file and reload systemd. The next time this service is run
# (either manually or via a systemd timer), the overridden values will be in
# effect.
#
# For more information about systemd drop-in files, see systemd.unit(5).

[Unit]
Description=Insights Client
Documentation=man:insights-client(8)
After=network.target

[Service]
Type=simple
ExecStart=/usr/bin/insights-client --retry 3
Restart=no
WatchdogSec=900
CPUQuota=30%
MemoryLimit=2G
TasksMax=300
BlockIOWeight=100
ExecStartPost=-/bin/bash -c "echo 2G >/dev/null 2>&1 > /sys/fs/cgroup/memory/system.slice/insights-client.service/memory.memsw.limit_in_bytes"
ExecStartPost=-/bin/bash -c "echo 1G >/dev/null 2>&1 > /sys/fs/cgroup/memory/system.slice/insights-client.service/memory.soft_limit_in_bytes"
```

Since RHEL 9 is mounting the cgroup-v2 hierarchy by default, these commands in the ExecStartPost fields will always fail.

Unfortunately, I am not a cgroup-v2 expert, but I believe that changing the unit file to use the systemd memory options for cgroup-v2 would be the right path forward.

See:  https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/managing_monitoring_and_updating_the_kernel/assembly_configuring-resource-management-using-systemd_managing-monitoring-and-updating-the-kernel#ref_memory-allocation-configuration-options-with-systemd_assembly_configuring-resource-management-using-systemd_managing-monitoring-and-updating-the-kernel


My proposal:

```
$ sudo systemctl cat insights-client.service 
# /usr/lib/systemd/system/insights-client.service
# This file is part of insights-client.
#
# Any changes made to this file will be overwritten during a software update. To
# override a parameter in this file, create a drop-in file, typically located at
# /etc/systemd/system/insights-client.service.d/override.conf. Put the desired
# overrides in that file and reload systemd. The next time this service is run
# (either manually or via a systemd timer), the overridden values will be in
# effect.
#
# For more information about systemd drop-in files, see systemd.unit(5).

[Unit]
Description=Insights Client
Documentation=man:insights-client(8)
After=network.target

[Service]
Type=simple
ExecStart=/usr/bin/insights-client --retry 3
Restart=no
WatchdogSec=900
CPUQuota=30%
MemoryLimit=1G
MemorySwapMax=2G
TasksMax=300
BlockIOWeight=100
```

This does the following:

- removes the ExecStartPost entries
- reduces MemoryLimit to 1G to match the value of `memory.soft_limit_in_bytes` from the removed ExecStartPost command
- adds MemorySwapMax=2G to match the value of `memory.memsw.limit_in_bytes` from the removed ExecStartPost command

I'm not certain that MemoryLimit and MemorySwapMax are direct replacements for the cgroup=-v1 options, but it was the best guess that I made after consulting the Memory Resource Controller docs - https://www.kernel.org/doc/html/latest/admin-guide/cgroup-v1/memory.html#benefits-and-purpose-of-the-memory-controller


NOTE: this change would only be applicable for RHEL9 as RHEL8 still mounts cgroup-v1 by default

Comment 3 RHEL Program Management 2023-09-07 13:07:15 UTC
Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 4 RHEL Program Management 2023-09-07 13:12:27 UTC
This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues.


Note You need to log in before you can comment on or make changes to this bug.