Bug 211772 - gitk doesn't respect $GIT_OBJECT_DIRECTORY
Summary: gitk doesn't respect $GIT_OBJECT_DIRECTORY
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: git
Version: 5
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chris Wright
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-10-22 15:47 UTC by Frank Ch. Eigler
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version: git-1_5_0_2-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-03-19 23:29:18 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Frank Ch. Eigler 2006-10-22 15:47:35 UTC 
Description of problem:
gitk dies if GIT_OBJECT_DIRECTORY being set means .git/objects is replaced
by a directory elsewhere

Version-Release number of selected component (if applicable):
gitk-1.4.2.4-1.fc5

How reproducible:
always

Steps to Reproduce:
1. set GIT_OBJECT_DIRECTORY
2. check out some git repo
3. observer that .git/objects does not exist
4. run gitk in same directory
  
Actual results:
gitk crashes

Expected results:
gitk should run

Additional info:
Putting a symlink .git/objects -> $GIT_OBJECT_DIRECTORY kludges around this
Comment 1 Frank Ch. Eigler 2006-11-28 04:50:54 UTC 
According to an strace, this appears to come from git ls-remote => git-peek-remote
Comment 2 Chris Wright 2007-03-19 23:29:18 UTC 
This works fine for me.  peek-remote has been properly using setup_git_directory
since version git version 1.0 AFAICT.  And current gitk no longer use ls-remote,
but instead uses show-ref (since 1.5.0.x).  I'm closing this as CURRENTRELASE,
starting with 1.5.0.2.  Please reopen if this is still a problem.
Note You need to log in before you can comment on or make changes to this bug.