Spec URL: https://dcavalca.fedorapeople.org/review/crosstool-ng/crosstool-ng.spec SRPM URL: https://dcavalca.fedorapeople.org/review/crosstool-ng/crosstool-ng-1.25.0-1.fc38.src.rpm Description: Crosstool-NG is a versatile (cross) toolchain generator. It supports many architectures and components and has a simple yet powerful menuconfig-style interface. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=91441924
The license field and files seem incomplete: per COPYING (or LICENSE, both are identical), documentation is under CC-BY-SA-2.5 the license texts for all the licenses are in licenses.d/ -- there's both gpl.txt and lgpl.txt (which per COPYING, applies to some patches -- though I don't see a patches/ directory. We'll have to look deeper. The CC-BY-SA licenses are in licenses.d/by-sa -- bad news is, these are HTML files with separate CSS. So you might just want to manually declare the `by-sa/` folder itself as `%license` and see what happens.
Spec URL: https://dcavalca.fedorapeople.org/review/crosstool-ng/crosstool-ng.spec SRPM URL: https://dcavalca.fedorapeople.org/review/crosstool-ng/crosstool-ng-1.25.0-1.fc38.src.rpm Changelog: - update license and include missing license files
Almost there: the documentation is actually in /usr/share/doc/crosstool-ng, not in /usr/share/doc/crosstool-ng-data. Should it actually be part of crosstool-ng instead of crosstool-ng-data? (and the license files too). Also: rpmlint output is very noisy (Firefox choked on pasting the review text if I didn't omit them). A lot of them looks like it's due to the way this works though (configs for multiple versions of the same tools, carrying the same patches) but the zero-length files are weird. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: crosstool-ng-data : /usr/share/crosstool-ng/packages/moxiebox/sha.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 2", "[generated file]", "FSF Unlimited License (with License Retention) [generated file]", "FSF Unlimited License [generated file]", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 2.1", "GNU General Public License v3.0 or later", "FSF All Permissive License", "FSF Unlimited License (with License Retention) GNU Lesser General Public License GNU General Public License", "FSF Unlimited License (with License Retention)", "GNU General Public License v2.0 or later", "*No copyright* [generated file]", "GNU General Public License v2.0 or later [generated file]", "X11 License [generated file]", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]", "GNU Lesser General Public License v2.1 or later", "GNU General Public License", "X11 License", "*No copyright* X11 License", "BSD 3-Clause License". 1532 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/2122763-crosstool-ng/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc/crosstool-ng [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/crosstool-ng [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/bash- completion(python3-trezor, yadifa, mdbtools, swaylock, skim, timew, playerctl, filesystem, fedpkg, clevis, vultr-cli, lmms, rpmspectool, zypper, mtr, glib2, chatty, copydeps, reprepro, licensecheck, python3-catkin_tools, sway, bubblewrap, gitleaks, hcloud, osslsigncode, chocolate-doom, git-delta, gopass, fd-find, datamash, hashcat, stress-ng, azure-cli, zola, libmbim-utils, mt-st, devscripts- checkbashisms, yadifa-tools, tracker, mercurial, task, falkon, gh, bodhi-cli, etckeeper, skopeo, swayidle, beaker-client, repo, dosbox- staging, hstr, ldc, pdfgrep, switchtec, docker-compose, rpmdevtools, tealdeer, dnf, bfs, git-core, wlogout, breezy, cpu-x, source- highlight, golang-github-tdewolff-minify, restic, buildah, toolbox, dub, policycoreutils, maven, cobbler, lxi-tools, hyperfine, alacritty, darcs, calf, libqmi-utils, composer, tldr, xca, fedora-update- feedback, rubygem-ronn-ng, httpie, zeitgeist, vagrant, subversion, nnn, ModemManager, python3-tqdm, dotnet-host, bash-completion, ethtool, python3-streamlink, ripgrep, eg, gpaste, croc, dconf-editor, vcsh, flatpak, stratis-cli, tio, ffsend, python-django-bash- completion, linode-cli, pbuilder, poetry, devscripts, nitrokey-app, exa, monotone, gammu, awscli, docopt, kmod, lxc, just, exercism, pcp, lightdm, smc-tools, driverctl), /usr/share/bash- completion/completions(python3-trezor, yadifa, mdbtools, skim, kompose, swaylock, timew, playerctl, environment-modules, filesystem, fedpkg, clevis, vultr-cli, lmms, rpmspectool, zypper, firejail, nbdkit-bash-completion, mtr, minipro, glib2, chatty, copydeps, reprepro, licensecheck, python3-catkin_tools, sway, python3-pip, bubblewrap, flameshot, gitleaks, hcloud, osslsigncode, chocolate-doom, xss-lock, git-delta, gopass, fd-find, coccinelle-bash-completion, datamash, hashcat, stress-ng, azure-cli, zola, libmbim-utils, mt-st, devscripts-checkbashisms, yadifa-tools, tracker, nordugrid-arc-client, task, falkon, gh, bodhi-cli, etckeeper, skopeo, swayidle, beaker- client, repo, dosbox-staging, hstr, ldc, GMT-common, pdfgrep, switchtec, docker-compose, rpmdevtools, tealdeer, dnf, bfs, git-core, wlogout, breezy, cpu-x, source-highlight, golang-github-tdewolff- minify, restic, buildah, toolbox, dub, libappstream-glib, maven, cobbler, lxi-tools, hyperfine, alacritty, darcs, calf, libqmi-utils, composer, tldr, xca, fedora-update-feedback, rubygem-ronn-ng, httpie, zeitgeist, vagrant, subversion, nnn, ModemManager, calibre, python3-tqdm, dotnet-host, bash-completion, ethtool, python3-streamlink, ripgrep, opensc, eg, gpaste, croc, dconf-editor, vcsh, flatpak, stratis-cli, tio, ffsend, python-django-bash- completion, libnbd-bash-completion, linode-cli, pbuilder, poetry, packit, devscripts, libguestfs-bash-completion, nitrokey-app, exa, monotone, guestfs-tools-bash-completion, gammu, firewalld, awscli, docopt, kmod, lxc, just, exercism, lastpass-cli, tig, pcp, lightdm, smc-tools, driverctl) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [?]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 112640 bytes in 14 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in crosstool-ng-data [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM.
Spec URL: https://dcavalca.fedorapeople.org/review/crosstool-ng/crosstool-ng.spec SRPM URL: https://dcavalca.fedorapeople.org/review/crosstool-ng/crosstool-ng-1.25.0-1.fc38.src.rpm Changelog: - move docs to the main package and install licenses in both
Looks fine now, except for the licenses You probably do want to go through the list of projects bundled and see what the upstream licenses are These are some (but not all) that I found: $ find . -name '*.patch' | sed -e 's/^\.\///g' | sed -e 's/\/.*//g' | sort | uniq binutils binutils-oracle duma elf2flt gcc gcc-linaro gdb gettext glibc glibc-ports gmp gnuprumcu libelf libtool ltrace make mingw-w64 moxiebox ncurses newlib newlib-nano picolibc strace uClibc-ng zlib ❯ cat find-crosstool-licenses.sh #!/bin/bash PKGS=$(find . -name '*.patch' | sed -e 's/^\.\///g' | sed -e 's/\/.*//g' | sort | uniq) SPECS_DIR=~/src/fedora/rpm-specs for p in ${PKGS}; do spec=${SPECS_DIR}/${p}.spec if [ -f ${spec} ]; then echo $p grep License: ${spec} fi done ❯ bash find-crosstool-licenses.sh binutils License: GPLv3+ gcc License: GPLv3+ and GPLv3+ with exceptions and GPLv2+ with exceptions and LGPLv2+ and BSD gdb License: GPLv3+ and GPLv3+ with exceptions and GPLv2+ and GPLv2+ with exceptions and GPL+ and LGPLv2+ and LGPLv3+ and BSD and Public Domain and GFDL License: GFDL gettext License: GPLv3+ and LGPLv2+ and GFDL License: GPLv3+ License: LGPLv2+ and GPLv3+ and GFDL License: LGPLv2+ and GPLv3+ glibc License: LGPLv2+ and LGPLv2+ with exceptions and GPLv2+ and GPLv2+ with exceptions and BSD and Inner-Net and ISC and Public Domain and GFDL gmp License: LGPLv3+ or GPLv2+ libtool License: GPLv2+ and LGPLv2+ and GFDL License: LGPLv2+ License: LGPLv2+ ltrace License: GPLv2+ make License: GPLv3+ ncurses License: MIT strace License: LGPL-2.1+ and GPL-2.0+ zlib License: zlib and Boost
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.