Bug 2127788 - [RFE] Messages of insights-client are not localized
Summary: [RFE] Messages of insights-client are not localized
Keywords:
Status: NEW
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: insights-client
Version: 9.1
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: CSI Client Tools Bugs
QA Contact: Red Hat subscription-manager QE Team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-09-19 02:38 UTC by Lijun Li
Modified: 2023-07-21 23:16 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-134229 0 None None None 2022-09-19 02:41:18 UTC

Description Lijun Li 2022-09-19 02:38:25 UTC
Description of problem:
[ALL LANG] Unexpected code and Unlocalized strings in the pop-up error messages box when registering system with 'Connect this system to Red Hat Insights'.

Version-Release number of selected component (if applicable):
subscription-manager-1.29.30-1.el9.x86_64
subscription-manager-cockpit-4-1.el9.noarch

How reproducible:
100%

Steps to Reproduce:
1. Open RHSM Cockpit Client via click Applications - System Tools - Red Hat Subscription Manager on the top menu bar from desktop or type subscription in the search field and press the Enter key.
2. Click Register button in Subscriptions dialog box.
3. Select Custom URL and input the correct URL.
4. Input the correct Username and Password.
5. Select the 'Connect this system to Red Hat Insights' checkbox.
6. Click Register button.

Actual results:
[ALL LANG] Unexpected code and Unlocalized strings in the pop-up error messages box when registering system with 'Connect this system to Red Hat Insights'.

Expected results:
1. No such debug info and code in the error message box.
2. The strings should be localized in the error message box.

Additional info:
Please see the attached screen-shot.

Comment 2 Pino Toscano 2022-09-20 08:07:07 UTC
Hmm this is the stdout/stderr of the `insights-client` command, so we simply show what is printed. Maybe running `insights-client` with a different language will give some of the messages as translated.

Can you please run `insights-client` from a terminal (i.e. outside of cockpit) where the language is different than English? (check the output of `localectl`)

Comment 3 Pino Toscano 2022-09-20 14:32:01 UTC
Link Dupont (developer of insights-client) told me that insights-client does not support localization so far. Hence, reassigning this to that component, as there is nothing the cockpit plugin of subscription-manager can do about this.

Please note that the HTML code shown in the error message is simply the answer from the server, and that cannot be localized in any way.

Comment 4 Lijun Li 2023-04-25 07:03:58 UTC
Reproduced on latest RHEL9.2 build also.

Comment 5 Lijun Li 2023-04-25 07:25:14 UTC
Unlocalized message:

insights-client exited with code 1

Comment 6 Pino Toscano 2023-04-26 08:15:45 UTC
(In reply to Lijun Li from comment #4)
> Reproduced on latest RHEL9.2 build also.

Note that this does not need to be periodically rested: the issue here is not something more or less easily fixable, it's a structural lack of i18n in insights-client, so it will require a considerable amount of effort to be done.

Comment 7 Lijun Li 2023-04-26 08:30:25 UTC
(In reply to Pino Toscano from comment #6)
> (In reply to Lijun Li from comment #4)
> > Reproduced on latest RHEL9.2 build also.
> 
> Note that this does not need to be periodically rested: the issue here is
> not something more or less easily fixable, it's a structural lack of i18n in
> insights-client, so it will require a considerable amount of effort to be
> done.

Sure, thanks for the info.

Comment 8 Ludek Janda 2023-04-26 08:40:00 UTC
The risk is that if "insights-client" is not i18n'ed properly, this issue might be reported again and again. At least the result of this bug should be a ticket to get "insights-client" localized....

Comment 9 Pino Toscano 2023-04-26 10:06:04 UTC
(In reply to Ludek Janda from comment #8)
> The risk is that if "insights-client" is not i18n'ed properly, this issue
> might be reported again and again. At least the result of this bug should be
> a ticket to get "insights-client" localized....

Let me clarify what I said earlier: it was not meant to dismiss the work/testing, but rather point out this is not a trivial change that will happen overnight or with a 5-lines patch; because of that, it needs to scheduled, have a design on how to plug i18n in the existing architecture, be actually implemented and tested. As such, if there are updates, then definitely anything will be shared here, in terms of links to upstream changes, documents, and even calls for translations.

Hence, a periodic retest on this bug, in the lack of updates, if very likely to give the same results again and again, i.e. that insights-client is not i18n'ed.

Comment 10 Ludek Janda 2023-04-26 10:22:17 UTC
(In reply to Pino Toscano from comment #9)
> (In reply to Ludek Janda from comment #8)
> > The risk is that if "insights-client" is not i18n'ed properly, this issue
> > might be reported again and again. At least the result of this bug should be
> > a ticket to get "insights-client" localized....
> 
> Let me clarify what I said earlier: it was not meant to dismiss the
> work/testing, but rather point out this is not a trivial change that will
> happen overnight or with a 5-lines patch; because of that, it needs to
> scheduled, have a design on how to plug i18n in the existing architecture,
> be actually implemented and tested. As such, if there are updates, then
> definitely anything will be shared here, in terms of links to upstream
> changes, documents, and even calls for translations.
> 
> Hence, a periodic retest on this bug, in the lack of updates, if very likely
> to give the same results again and again, i.e. that insights-client is not
> i18n'ed.

No worries, I understand the complexity. However I think there should be a clear requirement for the authors of "insights-client" to get their component i18n'ed properly. Subscription manager is i18n'ed and if they want to integrate with it, this component should be i18n'ed too IMO.

Comment 11 Ludek Janda 2023-04-26 11:10:04 UTC
Oh sorry, Pino. I can see that this ticket is already an RFE. Then it is okay.


Note You need to log in before you can comment on or make changes to this bug.