Bug 2144740 - Probably doens't comply with Rust packaging guidelines
Summary: Probably doens't comply with Rust packaging guidelines
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: device-mapper-persistent-data
Version: 37
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Marian Csontos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-11-22 07:40 UTC by David Abdurachmanov
Modified: 2023-08-02 02:20 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description David Abdurachmanov 2022-11-22 07:40:39 UTC
Description of problem:

While trying to update some dependencies for device-mapper-persistent-data on Fedora/RISCV F37 I noticed that this package might not comply with Rust Packaging Guidelines.

1. The package use vendor directory for the dependencies, instead of packaging dependencies in Fedora.
2. Vendor directory is updated via a separate tarball (are there any modifications?), that also incl. .*a static libraries for winapi:

[..]
-rw-r--r-- mcsontos/mcsontos  112526 2021-06-28 14:11 ./vendor/winapi-x86_64-pc-windows-gnu/lib/libwinapi_wintrust.a
-rw-r--r-- mcsontos/mcsontos   32218 2021-06-28 14:11 ./vendor/winapi-x86_64-pc-windows-gnu/lib/libwinapi_winusb.a
-rw-r--r-- mcsontos/mcsontos   54228 2021-06-28 14:11 ./vendor/winapi-x86_64-pc-windows-gnu/lib/libwinapi_wlanapi.a
-rw-r--r-- mcsontos/mcsontos    4046 2021-06-28 14:11 ./vendor/winapi-x86_64-pc-windows-gnu/lib/libwinapi_wlanui.a
-rw-r--r-- mcsontos/mcsontos  194972 2021-06-28 14:11 ./vendor/winapi-x86_64-pc-windows-gnu/lib/libwinapi_wldap32.a
[..]

3. The package doesn't contain any Provides: bundled(crate(foo)) = version for bundled stuff.
4. The package doesn't use required %cargo_prep macro, instead creating it's own .cargo/config file.

Version-Release number of selected component (if applicable):

Fedora 37, device-mapper-persistent-data-0.9.0-8.fc37


Note You need to log in before you can comment on or make changes to this bug.