Spec URL: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/05178090-qwtplot3d-qt6/qwtplot3d-qt6.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/05178090-qwtplot3d-qt6/qwtplot3d-qt6-0.3.0-1.20210828gitb265574.fc38.src.rpm Description: Qt6 QwtPlot3D Fedora Account System Username: sagitter
Just a quick suggestion for future-proofness / analogy with other Qt libraries: I'd call the base package qwtplot3d and then the subpackage qwtplot3d-qt6, which then allows you to add say qwtplot3d-qt7 without renaming the source repo or requiring an additional source repo. BTW, there appears to be no BR: qwt-qt6-devel or equivalent?
1. Need to change License name to Zlib. 2. Remove %global gittag %{commit} as unused. 3. Change Source0: https://github.com/SciDAVis/qwtplot3d/archive/%{commit}/qwtplot3d-%{commit}.tar.gz to Source0: %{url}/archive/%{commit}/qwtplot3d-%{commit}.tar.gz 4. It is really necessary? Requires: cmake(Qt6Core) Requires: cmake(Qt6Gui) 5. Change %autosetup -n qwtplot3d-%{commit} -N %patch0 -p1 -b .backup to %autosetup -p1 -n qwtplot3d-%{commit} -N
6. Change Buildrequires: to BuildRequires: 7. Need to review options list for %cmake because some of them not used: BUILD_EXAMPLES QT_QMAKE_EXECUTABLE QWT_INCLUDE_DIR QWT_LIBRARY QWT_VERSION_STRING SELECT_QT WITH_ZLIB 8. As I see zlib not used for build at all.
(In reply to Sandro Mani from comment #1) > Just a quick suggestion for future-proofness / analogy with other Qt > libraries: I'd call the base package qwtplot3d and then the subpackage > qwtplot3d-qt6, which then allows you to add say qwtplot3d-qt7 without > renaming the source repo or requiring an additional source repo. BTW, there > appears to be no BR: qwt-qt6-devel or equivalent? I have re-named this package as qwtplot3d-qt Probably, a Qt5 sub-package could obsolete the `qwtplot3d-qt5` rpm (In reply to Vasiliy Glazov from comment #2) > > 5. Change > %autosetup -n qwtplot3d-%{commit} -N > > %patch0 -p1 -b .backup > to > %autosetup -p1 -n qwtplot3d-%{commit} -N I prefer to use the %%patch command apart. Let me work better to this package
Why not just qwtplot3d? Packages should use the upstream name, and the Qt "q" is already in the q of qwt (Qt Widgets for Technical applications).
(In reply to Sandro Mani from comment #5) > Why not just qwtplot3d? Packages should use the upstream name, and the Qt > "q" is already in the q of qwt (Qt Widgets for Technical applications). qwtplot3d already exists in Fedora
Ah right now I see - qwtplot3d is dead upstream and qt3/qt4 only though, and AFAICS no packages depend on either. What about switching that package to the more recent fork and dropping qt3/qt4?
(In reply to Sandro Mani from comment #7) > Ah right now I see - qwtplot3d is dead upstream and qt3/qt4 only though, and > AFAICS no packages depend on either. What about switching that package to > the more recent fork and dropping qt3/qt4? Yes, probably it's the better choice
I'm closing this ticket. Thank you Vasiliy and Sandro