Bug 2160214 - Review Request: golang-github-alecthomas-assert-2 - A simple assertion library using Go generics
Summary: Review Request: golang-github-alecthomas-assert-2 - A simple assertion librar...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2148832 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-01-11 19:28 UTC by W. Michael Petullo
Modified: 2023-04-18 21:52 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-04-18 21:52:55 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2023-01-11 19:28:06 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-alecthomas-assert-2.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-alecthomas-assert-2-2.2.1-1.fc37.src.rpm
Description: A simple assertion library using Go generics.
Fedora Account System Username: mikep

Comment 1 Jakub Kadlčík 2023-01-11 19:31:10 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5218129
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2160214-golang-github-alecthomas-assert/fedora-rawhide-x86_64/05218129-golang-github-alecthomas-assert-2/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 2 Mikel Olasagasti Uranga 2023-01-12 15:38:42 UTC
*** Bug 2148832 has been marked as a duplicate of this bug. ***

Comment 3 Mikel Olasagasti Uranga 2023-01-12 16:12:19 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 4 W. Michael Petullo 2023-01-12 16:37:07 UTC
https://pagure.io/releng/fedora-scm-requests/issue/50424

Comment 5 Fedora Admin user for bugzilla script actions 2023-01-12 16:37:10 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-assert-2


Note You need to log in before you can comment on or make changes to this bug.