Bug 2160687 - pyproject-rpm-macros: FTBFS due to %check failures with tox 4
Summary: pyproject-rpm-macros: FTBFS due to %check failures with tox 4
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: pyproject-rpm-macros
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL: https://koschei.fedoraproject.org/pac...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-01-13 10:32 UTC by Miro Hrončok
Modified: 2023-01-17 23:27 UTC (History)
5 users (show)

Fixed In Version: pyproject-rpm-macros-1.5.1-1.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-17 23:27:53 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2023-01-13 10:32:34 UTC
See https://koschei.fedoraproject.org/package/pyproject-rpm-macros?collection=f38

Since tox 4, we have the following 4 test failures:

tox now generates a dependency on self:

E                   python3dist(setuptools) >= 40.8
E                   python3dist(wheel)
E                   python3dist(wheel)
E                   python3dist(tox-current-env) >= 0.0.6
E                 + python3dist(tox)
E                   python3dist(toxdep1)
E                   python3dist(toxdep2)
E                   python3dist(inst)

and

E                   python3dist(setuptools) >= 40.8
E                   python3dist(wheel)
E                   python3dist(wheel)
E                   python3dist(tox-current-env) >= 0.0.6
E                 + python3dist(tox)
E                   python3dist(toxdep)
E                   python3dist(inst)
E                   python3dist(dep11) > 11.0
E                   python3dist(dep12)
E                   python3dist(dep21)
E                   python3dist(dep22)
E                   python3dist(dep23)
E                   python3dist(extra-dep)
E                   python3dist(extra-dep[extra_dep])



tox now lists tox_minversion requirements in a different order:

E                   python3dist(setuptools) >= 40.8
E                   python3dist(wheel)
E                   python3dist(wheel)
E                   python3dist(tox-current-env) >= 0.0.6
E                 + python3dist(setuptools) > 40.0
E                   python3dist(tox) >= 3.5
E                 - python3dist(setuptools) > 40.0
E                   python3dist(toxdep1)
E                   python3dist(toxdep2)
E                   python3dist(inst)


E                   python3dist(setuptools) >= 40.8
E                   python3dist(wheel)
E                   python3dist(wheel)
E                   python3dist(tox-current-env) >= 0.0.6
E                   python3dist(tox) >= 3.999
E                   python3dist(setuptools) > 40.0
E                   python3dist(wheel) > 2.0
E                 + python3dist(tox) >= 3.999

The second diff is a tad weird because now tox is listed twice. I need to investigate.





The tests might be trivial to fix for tox 4 but it might be be a tad complex to make them work with tox 3 and tox 4. One possibility is to diverge the branches in dist-git.

Comment 1 Miro Hrončok 2023-01-13 10:43:31 UTC
The "tox is listed twice" is an imperfection of handling tox minversion.
In tox 4, the minversion requirement is also specified in requires.

Handling tox >= 3.999 from tox provision (minversion)
Handling setuptools>40 from tox provision (requires)
Handling wheel>2 from tox provision (requires)
Handling tox>=3.999 from tox provision (requires)

I don't think we need to care much, in case tox 4 ponce again changes this, it is better to be safe than sorry.

Comment 3 Fedora Update System 2023-01-17 23:25:15 UTC
FEDORA-2023-0b62dedf6f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0b62dedf6f

Comment 4 Fedora Update System 2023-01-17 23:27:53 UTC
FEDORA-2023-0b62dedf6f has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.