Spec URL: https://marcdeop.fedorapeople.org/flatpak-kcm.spec SRPM URL: https://marcdeop.fedorapeople.org/flatpak-kcm-5.26.90-1.fc37.src.rpm Description: Flatpak Permissions Management KCM Fedora Account System Username: marcdeop
Copr build: https://copr.fedorainfracloud.org/coprs/build/5282673 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2162953-flatpak-kcm/fedora-rawhide-x86_64/05282673-flatpak-kcm/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/kpackage/kcms/kcm_flatpak/contents/ui, /usr/share/kpackage/kcms/kcm_flatpak/contents, /usr/share/kpackage/kcms/kcm_flatpak, /usr/lib64/qt5/plugins/plasma/kcms/systemsettings, /usr/lib64/qt5/plugins/plasma/kcms [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/qt5/plugins/plasma, /usr/share/kpackage/kcms/kcm_flatpak, /usr/lib64/qt5/plugins/plasma/kcms, /usr/share/kpackage/kcms/kcm_flatpak/contents/ui, /usr/share/kpackage/kcms/kcm_flatpak/contents, /usr/lib64/qt5/plugins/plasma/kcms/systemsettings [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: flatpak-kcm-5.26.90-1.fc38.x86_64.rpm flatpak-kcm-debuginfo-5.26.90-1.fc38.x86_64.rpm flatpak-kcm-debugsource-5.26.90-1.fc38.x86_64.rpm flatpak-kcm-5.26.90-1.fc38.src.rpm ==================================================================================================================== rpmlint session starts ==================================================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2pvt8nj_')] checks: 31, packages: 4 flatpak-kcm.x86_64: W: no-documentation ===================================================================================== 4 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.4 s ===================================================================================== Rpmlint (debuginfo) ------------------- Checking: flatpak-kcm-debuginfo-5.26.90-1.fc38.x86_64.rpm ==================================================================================================================== rpmlint session starts ==================================================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpy4gue8b8')] checks: 31, packages: 1 ===================================================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s ===================================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 flatpak-kcm.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.4 s Unversioned so-files -------------------- flatpak-kcm: /usr/lib64/qt5/plugins/plasma/kcms/systemsettings/kcm_flatpak.so Source checksums ---------------- http://download.kde.org/unstable/plasma/5.26.90/flatpak-kcm-5.26.90.tar.xz : CHECKSUM(SHA256) this package : bf62e6cf2cd7eb6a02ab171d60fffd3fc80eb01c3f2dc85548661be556d0b7b7 CHECKSUM(SHA256) upstream package : bf62e6cf2cd7eb6a02ab171d60fffd3fc80eb01c3f2dc85548661be556d0b7b7 Requires -------- flatpak-kcm (rpmlib, GLIBC filtered): libKF5ConfigCore.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5I18n.so.5()(64bit) libKF5QuickAddons.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libc.so.6()(64bit) libflatpak.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) flatpak-kcm-debuginfo (rpmlib, GLIBC filtered): flatpak-kcm-debugsource (rpmlib, GLIBC filtered): Provides -------- flatpak-kcm: flatpak-kcm flatpak-kcm(x86-64) flatpak-kcm-debuginfo: debuginfo(build-id) flatpak-kcm-debuginfo flatpak-kcm-debuginfo(x86-64) flatpak-kcm-debugsource: flatpak-kcm-debugsource flatpak-kcm-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2162953 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Perl, R, Ocaml, SugarActivity, Haskell, fonts, Java, PHP, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
> License: BSD and GPLv2+ Please use SPDX notation: "BSD-2-Clause and BSD-3-Clause and CC0-1.0 and GPL-2.0-or-later" Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names > * Sun Jan 22 2023 Marc Deop marcdeop - 5.26.90-1 Author needs to be formatted "Marc Deop <marcdeop>" Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
Actually, the only part CC0-1.0 is the GitLab CI YAML, which we don't ship, so you can drop that stanza.
(In reply to Neal Gompa from comment #4) > Actually, the only part CC0-1.0 is the GitLab CI YAML, which we don't ship, > so you can drop that stanza. Welp, not really. Since it's in the source archive, it needs to be listed. Yay. :(
Exception request made: https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/message/Q67KFP4NT3WEL2Z75BYCXMP2IOQHLBJT/
For the time being, I have updated the spec file with your requests Neal. (and updated my vim UltiSnip to use the proper format for the email)
> %autosetup -n %{name}-%{version} -p1 The "-n %{name}-%{version}" is redundant (that's the default). You can drop it.
(In reply to Neal Gompa from comment #8) > > %autosetup -n %{name}-%{version} -p1 > > The "-n %{name}-%{version}" is redundant (that's the default). You can drop > it. Fixed
An exception has been granted for REUSE-enforced usage of CC0-1.0: https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/message/LVU6X3YHTKKGW4YB5KQT7LWSFD555XAP/ I'm lifting FE-Legal now. With no other issues left, this package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/flatpak-kcm
Done