Bug 2165231 - wxGTK should require redhat-lsb-core
Summary: wxGTK should require redhat-lsb-core
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: wxGTK
Version: 38
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Scott Talbert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-01-28 17:39 UTC by Steven A. Falco
Modified: 2023-07-14 16:16 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-07-14 16:16:43 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Steven A. Falco 2023-01-28 17:39:27 UTC
Description of problem:

wxGTK provides a call "wxGetLinuxDistributionInfo()".  Internally, that call uses the "lsb_release" command from the redhat-lsb-core package.

However, wxGTK doesn't have a "Requires" for redhat-lsb-core, so it cannot return the distribution information unless some other package has pulled in redhat-lsb-core.

Note also the comment in the source code around line 1167 in utilsunx.cpp:

        // Don't bother to continue, lsb_release is probably not available.
        return ret;

Therefore, I think wxGTK should require redhat-lsb-core.


Version-Release number of selected component (if applicable):


How reproducible: 100%


Steps to Reproduce: N/A


Actual results: N/A

 
Expected results: N/A


Additional info:

Comment 1 Scott Talbert 2023-01-31 03:21:49 UTC
Hmm, going to have to think about this one.  redhat-lsb-core seems to be dragging in a bunch of other stuff.  esmtp???

[talbert@deasil wxGTK]$ sudo dnf install redhat-lsb-core
Last metadata expiration check: 2:05:38 ago on Mon 30 Jan 2023 08:09:57 PM EST.
Dependencies resolved.
================================================================================
 Package                        Arch       Version             Repository  Size
================================================================================
Installing:
 redhat-lsb-core                x86_64     4.1-59.fc37         fedora      29 k
Installing dependencies:
 esmtp                          x86_64     1.2-20.fc37         fedora      52 k
 libesmtp                       x86_64     1.0.6-25.fc37       fedora      66 k
 mailx                          x86_64     12.5-42.fc37        fedora     261 k
 redhat-lsb-submod-security     x86_64     4.1-59.fc37         fedora     8.5 k
 spax                           x86_64     1.6-7.fc37          fedora     215 k
 util-linux-user                x86_64     2.38.1-1.fc37       fedora      30 k

Transaction Summary
================================================================================
Install  7 Packages

Comment 2 Ben Cotton 2023-02-07 15:06:50 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 3 Jeremy Newton 2023-06-11 17:08:10 UTC
What about a "recommends" instead of a "requires"? (allow for the user to opt out of the dependency)

Alternatively, there's also "suggests" for an even less strict dependency (in theory it should just hint to the user that wxGTK is enhanced by redhat-lsb-core)

If WXGTK gracefully handles a missing lsb_release, then it doesn't need to me a hard requirement
See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_dependency_types
https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/

Comment 4 Steven A. Falco 2023-06-11 19:04:11 UTC
Good points.  I've changed KiCad (the consumer of wxGTK that prompted this bug) to "recommend" redhat-lsb-core.  Using "suggests" means that most people won't install redhat-lsb-core, so "suggests" is unlikely to be helpful, IMO.

There was more discussion on gitlab and on the fedora devel list:

https://gitlab.com/kicad/packaging/kicad-fedora-builder/-/merge_requests/87

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/MVZA7BUFGTGAILFVMQWG6QGVIFUMDUXA/#MVZA7BUFGTGAILFVMQWG6QGVIFUMDUXA

In particular, it was mentioned that it would be better if wxGTK read the data directly from /etc rather than using an external tool.

Comment 5 Scott Talbert 2023-07-14 16:16:43 UTC
Closing this in favor of https://bugzilla.redhat.com/show_bug.cgi?id=2184391


Note You need to log in before you can comment on or make changes to this bug.