SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify-0.02-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify.spec Description: Perl bindings to libnotify. This module will allow one to use the notify functionality from within a perl application.
Tests now conditionalized -- they tend to die horribly under mock due to the lack of $DISPLAY. SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify-0.02-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify.spec
I just had a look for Source URL and found given source download link is not working.
Ok, that's weird. It is working from the by-authors perspective; I'll update the spec to use this one. http://search.cpan.org/CPAN/authors/id/F/FL/FLORA/Gtk2-Notify-0.02.tar.gz
Till you take time to update new SRPM here comes review Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and but NOT for RPMS. But those warnings are ignored. + source files match upstream. 77a64c944cf1516bcc514456de22a82b Gtk2-Notify-0.02.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + .pc file present. + no -devel subpackage exists + no .la files. + no translations are available + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Followed perl packaging guidelines. APPROVED.
I checked md5 against Source URL you provided. I can approve this package if you are going to include new source url while importing this package or submit new one . Will check it and then actually approve this package.
Updated with new source url: SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify-0.02-3.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify.spec
You forget to add version in Changelog entry. rpmlint is complaining for it now.
Fixed. SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify.spec
Thanks
Imported into cvs, branches requested, and building for devel. Thanks for the review! :)