Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/glump-0.9.11-1.fc6.spec SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/glump-0.9.11-1.fc6.src.rpm Description: Glump is a simple web application that glues files from various pieces, based on the hostname that makes the request. This is useful for large installations that want to send different files to different hosts.
Forbidden You don't have permission to access /misc/fedora/6/SRPMS/glump-0.9.11-1.fc6.spec on this server.
(In reply to comment #1) > > You don't have permission to access /misc/fedora/6/SRPMS/glump-0.9.11-1.fc6.spec > on this server. Whoops! Fixed...
I cannot see your spec/srpm as access seems forbidden...
(In reply to comment #3) > I cannot see your spec/srpm as access seems forbidden... The spec file that was stored in the SRPM didn't have world read permissions set, so when my script that I use to publish SRPMS to my web server extracted the specfile it overwrote the permissions. I've updated the SRPM with a spec file that has the proper permissions. Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/glump-0.9.11-2.fc6.spec SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/glump-0.9.11-2.fc6.src.rpm
Amazing that nobody's looked at this yet; it seems a simple enough package.
1) I noticed and it's making rpmlint sad too, that you are not using correct tab spaces in your spec file. 2) Your %install must have a "cleaning" buildroot section, I recommend you start with: %install rm -rf %{buildroot}
Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/glump-0.9.11-3.fc6.spec SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/glump-0.9.11-3.fc6.src.rpm I've updated the package to reflect Marek's comments.
Crap, I was typing this up but had to break for dinner before I could submit it. Here's what I wrote: rpmlint output is OK: W: glump mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 13) Not a blocker; fix it if you wish. E: glump explicit-lib-dependency libxml2-python This is a false positive. The package is necessary, and the dependency generator doesn't find it automatically. Marek is right; you should clean the buildroot at the beginning of install. Usually rpmlint complains about that; I'm not sure why it didn't. * source files match upstream: 634325e4efb057c5b849bf831a51ce8e7e11cec572b6769e9645f06443ae51ab glump-0.9.11.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint has only acceptable complaints. * final provides and requires are sane: config(glump) = 0.9.11-2.fc8 glump = 0.9.11-2.fc8 = /usr/bin/python config(glump) = 0.9.11-2.fc8 httpd libxml2-python mod_python * %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
And now looking at the -3 package, I see you fixed everything I had an issue with, so we're ready to go. APPROVED
New Package CVS Request ======================= Package Name: glump Short Description: A small web application to glue files from multiple sources Owners: jeff Branches: devel F-7 FC-6 EL-5 InitialCC:
Gahhh... hit "save changes" too soon... Jason... thanks for the review! You guys are really rockin' on the reviews... New Package CVS Request ======================= Package Name: glump Short Description: A small web application to glue files from multiple sources Owners: jeff Branches: devel F-7 FC-6 EL-5 InitialCC:
CVS done.
Thanks everyone!