Bug 2186915 - blkid output changed causing boot failures in rawhide
Summary: blkid output changed causing boot failures in rawhide
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: util-linux
Version: 39
Hardware: aarch64
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Karel Zak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-14 20:15 UTC by Jeremy Linton
Modified: 2024-11-27 21:10 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-11-27 21:10:54 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jeremy Linton 2023-04-14 20:15:21 UTC
Description of problem: I upgraded one of my older rawhide installs this morning and the machine failed to boot both with the new 6.3rc6 kernel and the older 6.2.2 kernel. Using that kernel it looked like my machine was unable to find the root by UUID anymore so I switched the fstab entries to PARTUUID, but then realized the xfs modules/etc were missing from the newer 6.3 initrd. Debuging dracut lead me to notice that the blkid type wasn't being printed

# blkid |grep sda4
/dev/sda4: PARTUUID="2f162043-63c2-d145-869b-e53f9db57476"

vs an older blkid

#./blkid |grep sda4
/dev/sda4: UUID="45b931b7-592a-46dc-9c33-d38d5901ec29" BLOCK_SIZE="4096" TYPE="xfs" PARTUUID="2f162043-63c2-d145-869b-e53f9db57476"

Which is a problem because dracut and a few other scripts need to be give the TYPE="xfs" bits in order to enable XFS. The lack of UUID= bits causes problems elsewhere too.





Version-Release number of selected component (if applicable):


How reproducible: 100% on my machine, not tried it elsewhere


Steps to Reproduce:
1. Upgrade to util-linux 2.39 on a machine with an old (fedora 31 timeframe) XFS filsystem
2. run blkid
3.

Actual results:

# blkid |grep sda4
/dev/sda4: PARTUUID="2f162043-63c2-d145-869b-e53f9db57476"

Expected results:
#./blkid |grep sda4
/dev/sda4: UUID="45b931b7-592a-46dc-9c33-d38d5901ec29" BLOCK_SIZE="4096" TYPE="xfs" PARTUUID="2f162043-63c2-d145-869b-e53f9db57476"


Additional info:
Downgrading the machine to libblkid-devel-2.38.1-4.fc38 fixes it.

Comment 1 Jeremy Linton 2023-04-14 20:16:29 UTC
I'm attempting to bisect it with an upstream clone at the moment.

Comment 2 Jeremy Linton 2023-04-14 20:27:13 UTC
The bisect reports: [5e98d8edba109518dfd3f922ee920a4c7d084272] libblkid: xfs: add more superblock fields

Comment 3 Jeremy Linton 2023-04-14 20:38:34 UTC
Although the log reports: 140968: libblkid: LOWPROBE: [31] xfs:
140968: libblkid:   BUFFER: 	reuse: off=0 len=1024 (for off=0 len=1024)
140968: libblkid: LOWPROBE: 	magic sboff=0, kboff=0
140968: libblkid: LOWPROBE: 	call probefunc()
140968: libblkid:   BUFFER: 	reuse: off=0 len=1024 (for off=0 len=272)
140968: libblkid: LOWPROBE: 	read: off=0 len=4096
140968: libblkid: LOWPROBE: incorrect checksum for type xfs, got FA0A3CA3, expected F93C4D8B
140968: libblkid: LOWPROBE: [32] xfs_external_log:
140968: libblkid: LOWPROBE: 	call probefunc()
140968: libblkid: LOWPROBE: 	read: off=0 len=262144

Comment 4 Jeremy Linton 2023-04-14 21:19:57 UTC
Ok, figured it out, it's clearing the wrong sb_crc resulting it computing the wrong CRC in blkid.

Comment 5 Jeremy Linton 2023-04-14 21:40:56 UTC
https://github.com/util-linux/util-linux/pull/2165

Comment 6 Karel Zak 2023-04-17 10:09:46 UTC
Thanks for debugging and bugfix! Fixed in the upstream tree, Fedora will be updated after the next v2.39 upgrade.

Comment 7 Fedora Release Engineering 2023-08-16 08:07:00 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.

Comment 8 Aoife Moloney 2024-11-08 10:51:27 UTC
This message is a reminder that Fedora Linux 39 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 39 on 2024-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '39'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 39 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 9 Aoife Moloney 2024-11-27 21:10:54 UTC
Fedora Linux 39 entered end-of-life (EOL) status on 2024-11-26.

Fedora Linux 39 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.