Bug 2192618 - Leapp treats each bind mounted xfs partition as if it was an xfs partition that requires an OVL image.
Summary: Leapp treats each bind mounted xfs partition as if it was an xfs partition th...
Keywords:
Status: NEW
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: leapp-repository
Version: 7.9
Hardware: x86_64
OS: Unspecified
low
medium
Target Milestone: rc
: ---
Assignee: Leapp Notifications Bot
QA Contact: upgrades-and-conversions
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-05-02 14:11 UTC by jcastran
Modified: 2023-08-15 08:52 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker OAMG-9036 0 None None None 2023-05-02 14:14:48 UTC
Red Hat Issue Tracker RHELPLAN-156213 0 None None None 2023-05-02 14:14:41 UTC

Description jcastran 2023-05-02 14:11:26 UTC
Description of problem:
When xfs partitions are bind mounted, leapp treats each one as an individual xfs partition. If we have ftype=0, then leapp assumes each one needs an overlay which increases the amount of space needed in /var/lib/leapp.

This customer had 12 xfs partitions, but only 2 were valid. The other 10 were bind mounts. Leapp reported that we needed 36GB (With a 3G OVL size) in /var/lib/leapp but upon reboot, only used 6-7 GB (as the bind mounts were not in the fstab so do not mount upon boot).


Version-Release number of selected component (if applicable):
leapp-0.15.0-2.el7_9.noarch 
leapp-deps-0.15.0-2.el7_9.noarch 
leapp-upgrade-el7toel8-0.17.0-10.el7_9.noarch     
leapp-upgrade-el7toel8-deps-0.17.0-10.el7_9.noarch
python2-leapp-0.15.0-2.el7_9.noarch

How reproducible:
Everytime

Steps to Reproduce:
1. Have a system with ftype=0 on an xfs partition
2. bind mount any xfs partitions any number of times
3. leapp upgrade

Actual results:
====> * target_userspace_creator
        Initializes a directory to be populated as a minimal environment to run binaries from the target system.
2023-04-27 10:24:27.525 ERROR    PID: 12215 leapp.workflow.TargetTransactionFactsCollection.target_userspace_creator: Not enough space available for creating required disk images in /var/lib/leapp/scratch. Needed: 36864 MiB

Expected results:
We could base calculations off only whats in the fstab to avoid bind mounts. 
Or a warning that # bind mounts are present and affecting this size estimate.

Additional info:

Comment 3 Petr Stodulka 2023-05-02 17:08:58 UTC
Lowering the priority as it's expected to be a corner case.


Note You need to log in before you can comment on or make changes to this bug.