Taking this review.

Initial spec review:

> %autosetup -n %{name}-%{version} -p1

The "-n %{name}-%{version}" is superfluous and can be dropped.

> %{cmake_kf5}

You can drop the curly braces here.

> %{_libdir}/libkjournald.so
> %{_libdir}/libkjournald.so.23
> %{_libdir}/libkjournald.so.23.04.2

This needs to be broken out to a -libs subpackage. The library seems to be versioned by the software version, so you'll want macros to track that.

For example, add the following to the top of the spec:

%global majorver 23
%global fullver %{majorver}.04.2

Then change the Version as follows:

Version: %{fullver}

Then change the file list as follows:

%{_libdir}/libkjournald.so
%{_libdir}/libkjournald.so.%{majorver}
%{_libdir}/libkjournald.so.%{fullver}

Changes made to the spec, and reuploaded the .spec and the .src.rpm to the server.

I used dolphin as an example of how to split libraries in a separate package (https://src.fedoraproject.org/rpms/dolphin/blob/rawhide/f/dolphin.spec), was wondering what the "%ldconfig_scriptlets libs" line did. I noticed after seeing https://asamalik.fedorapeople.org/tmp-docs-preview/packaging-guidelines/Scriptlets/ that it's no longer needed in the recent versions of Fedora, so I omitted it.

The dekstop file and appdata file need to be validated according to the fedora packaging guidelines.

ref: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files

(In reply to Felix Wang from comment #4)
> The dekstop file and appdata file need to be validated according to the
> fedora packaging guidelines.
> 
> ref: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files

Yep that's my bad, I copied a spec from another project and for whatever reason I deleted those lines... Added them back and updated the spec/srpm on the server.

Review notes:

* Packaging follows Fedora KDE packaging
* Packaging follows Fedora packaging guidelines
* Package builds and installs
* Package licensing is follows our guidelines

Looks good to me.

PACKAGE APPROVED.

The Pagure repository was created at https://src.fedoraproject.org/rpms/kjournald