Bug 2214051 - tracefs/tracefs.h: #include <event-parse.h> should be #include <traceevent/event-parse.h>
Summary: tracefs/tracefs.h: #include <event-parse.h> should be #include <traceevent/ev...
Keywords:
Status: ASSIGNED
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: libtracefs
Version: 9.2
Hardware: All
OS: Unspecified
unspecified
medium
Target Milestone: rc
: ---
Assignee: Michael Petlan
QA Contact: Qiao Zhao
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-06-11 11:51 UTC by Taketo Kabe
Modified: 2023-07-14 10:10 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-159452 0 None None None 2023-06-11 11:59:55 UTC

Description Taketo Kabe 2023-06-11 11:51:55 UTC
Description of problem:
#include <tracefs/tracefs.h> errors out on sub #include <event-parse.h> . 


Version-Release number of selected component (if applicable):
RHEL 9.2
libtracefs-devel-1.3.1-1.el9
libtraceevent-devel-1.5.3-3.el9 (dependency)

How reproducible:
always

Steps to Reproduce:

Prepare tracefs.c:
==========
#include <tracefs/tracefs.h>
==========
(yes, only 1 line)

$ cc -c tracefs.c


Actual results:
In file included from tracefs.c:2:
/usr/include/tracefs/tracefs.h:11:10: fatal error: event-parse.h: No such file or directory
   11 | #include <event-parse.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.


Expected results:
No error

Additional info:
This came evident when compiling custom kernel and compiling tools/tracing/rtls/ tree failed.

In /usr/include/tracefs/tracefs.c,
#include <event-parse.h> seems to be should be #include <traceevent/event-parse.h> .
Please disregard if I was wrong.

Comment 1 Michael Petlan 2023-06-22 15:48:34 UTC
Reproduced. Seems that you're right. However, upstream suffers from the same, so we'll discuss it upstream.

Comment 2 Michael Petlan 2023-07-14 10:10:50 UTC
Steven Rostedt does not consider this a bug:

==============================================================================
The pkgconfig for libtraceevent has:

 $ pkgconf --cflags libtraceevent
-I/usr/local/include/traceevent

Where it should include the path that includes "traceevent", as you should
not need to add it specifically.
==============================================================================

Using pkgconfig, the compilation should pass.


Note You need to log in before you can comment on or make changes to this bug.