Red Hat Bugzilla – Bug 221542
Changes to python-virtinst have caused virt-install to reject a VM name that contains a hyphen
Last modified: 2009-12-14 16:09:46 EST
I think this is something that should be fixed in RHEL5 too.
+++ This bug was initially created as a clone of Bug #221485 +++
Description of problem: Changes to
/usr/lib/python2.4/site-packages/virtinst/XenGuest.py have changed the behavior
of virt-install in a way that I find irritating. Our Xen guests have a hyphen
in their names, but virt-install rejects any name that has a hyphen in it now.
It was not this way in python-virtinst-0.95.0-1.fc6 , but it is so in
python-virtinst-0.98.0-1.fc6 . I traced the error back to this chunk of
def set_name(self, val):
# FIXME: need some validation here
if re.match("^[a-zA-Z0-9_]*$", val) == None:
raise ValueError, "Domain name must be alphanumeric or _"
This is unfortunate, because this new code restricts virtual machine names to
alphanumeric characters and the underscore. Now, a hyphen is a valid character
in a DNS A record (while an underscore character is not). I like my Xen guest
OS domain names to match their DNS names for obvious reasons. XenGuest.py
should allow any characters allowed in DNS names as a minimum.
Version-Release number of selected component (if applicable):
How reproducible: Try supplying a hyphenated name to virt-install, either on the
command line with the -n argument, or manually when virt-install prompts for a
name. It will reject any name with a hyphen in it.
Steps to Reproduce:
1. virt-install -n host-name
Actual results: ERROR: Domain name must be alphanumeric or _
Expected results: Completed virt-install with no errors
Additional info: There is a workaround: I created the virtual machine with an
underscore in the name instead of a hyphen. After the virt-install process and
Kickstart were finished, I renamed the /etc/xen/host_name file to
/etc/xen/host-name. Then I started the virtual machine and it is fine.
-- Additional comment from firstname.lastname@example.org on 2007-01-04 16:41 EST --
The regex is just a bit too restrictive. You should be able to add - to it
without problems and I've done so in hg, will be in the next build.
http://hg.et.redhat.com/virt/applications/virtinst--devel?cs=aec5777422c0 . Be
nice to get it into 5.1...
Should have proposed this for 5.1 much earlier. Is this getting pulled in already?
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release. Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products. This request is not yet committed for inclusion in an Update
This request was previously evaluated by Red Hat Product Management
for inclusion in the current Red Hat Enterprise Linux release, but
Red Hat was unable to resolve it in time. This request will be
reviewed for a future Red Hat Enterprise Linux release.
*** Bug 221664 has been marked as a duplicate of this bug. ***
As mentioned this fix is upstream and has been for awhile, so it should be easy
and low risk to bring in for RHEL5.2
Created attachment 290794 [details]
5.2 virtinst validation overhaul which fixes this issue
Setting dev ack for Dan.
Committed and built.
* Fri Jan 04 2008 Cole Robinson <email@example.com> - 0.103.0-6.el5
- Validation and error message fixes across the board.
- (rhbz #201948 #249424 #372001 #221542)
Build Tag Built by
---------------------------------------- -------------------- ----------------
python-virtinst-0.103.0-6.el5 dist-5E-qu-candidate crobinso
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.