Bug 2216301 - Review Request: rust-gix-quote - Deal with various quotations used by git
Summary: Review Request: rust-gix-quote - Deal with various quotations used by git
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-06-20 19:16 UTC by blinxen
Modified: 2023-06-28 21:18 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-06-28 21:18:50 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description blinxen 2023-06-20 19:16:11 UTC
Spec URL: https://blinxen.fedorapeople.org/rust-gix-quote/rust-gix-quote.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-gix-quote/rust-gix-quote-0.4.4-1.fc39.src.rpm
Description: A WIP crate of the gitoxide project dealing with various quotations used by git.
Fedora Account System Username: blinxen

Comment 1 Fabio Valentini 2023-06-27 23:40:30 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged
- license matches upstream specification (MIT/Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

=== 

Two minor issues:

- Upstream has released a new version, please update to v0.4.5 as soon as possible.
- Please fix the crate summary / description. It looks like you amended the bug title, but didn't apply the same change to the package itself. :)

Comment 2 Fedora Admin user for bugzilla script actions 2023-06-28 20:58:09 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-quote

Comment 3 blinxen 2023-06-28 21:18:50 UTC
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-32ce1aa93f


Note You need to log in before you can comment on or make changes to this bug.