Bug 221769 - Review Request: libcgi - CGI easy as C
Summary: Review Request: libcgi - CGI easy as C
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ruben Kerkhof
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-01-07 20:54 UTC by Jose Pedro Oliveira
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-07-01 02:11:00 UTC
Type: ---
Embargoed:
ruben: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Jose Pedro Oliveira 2007-01-07 20:54:06 UTC
Spec URL: 
ftp://perl.di.uminho.pt/pub/fedora/libcgi.spec

SRPM URL: 
ftp://perl.di.uminho.pt/pub/fedora/libcgi-1.0-1.src.rpm

Description:
LibCGI is a library written from scratch to easily make CGI applications in C.

Comment 1 Parag AN(पराग) 2007-01-10 10:15:33 UTC
Remove .a files from installation from -devel package.

Comment 2 Jose Pedro Oliveira 2007-01-10 21:05:11 UTC
I would like to ship the static library as I need to test to cgi apps for
embedded systems using this library. 
Would it be ok if I create a -static subpackage that would require the devel
subpackage?

Comment 3 Ralf Corsepius 2007-01-11 02:22:06 UTC
(In reply to comment #2)
> I would like to ship the static library as I need to test to cgi apps for
> embedded systems using this library. 
Are you running Fedora on this embedded system?

Comment 4 Parag AN(पराग) 2007-01-11 04:19:36 UTC
I think according to http://fedoraproject.org/wiki/PackagingDrafts/StaticLinkage
(Though its not a Final Draft), this document you need to get FESCO Approval to
include .a files.


Comment 5 Parag AN(पराग) 2007-02-22 05:07:01 UTC
any updates on above issue?

Comment 6 Jose Pedro Oliveira 2007-02-22 10:57:15 UTC
Sorry! I forgot to update this ticket.

New specfile that creates a -static subpackage:
ftp://perl.di.uminho.pt/pub/fedora/libcgi.spec
ftp://perl.di.uminho.pt/pub/fedora/libcgi-1.0-2.src.rpm

jpo

Comment 7 Jose Pedro Oliveira 2007-04-07 20:01:32 UTC
Any change of getting this package approved if I don't build the static
sub-package by default?

Comment 8 Parag AN(पराग) 2007-04-09 04:05:15 UTC
Sorry but would like to go by way written in comment4. Moreover you can ask
approval for same to include -static in Fedora on Fedora-maintainers list.

Comment 9 Jose Pedro Oliveira 2007-04-14 17:18:20 UTC
ftp://perl.di.uminho.pt/pub/fedora/libcgi.spec
ftp://perl.di.uminho.pt/pub/fedora/libcgi-1.0-3.src.rpm

Changelog:
No longer builds the static subpackage by default.

Comment 10 Ralf Corsepius 2007-04-15 05:46:53 UTC
To me, these files are named too general and are likely to conflict with future
packages:
/usr/include/cgi.h
/usr/include/session.h

Please move them into a subdirectory of %{_includedir}

Comment 11 Parag AN(पराग) 2007-04-15 18:18:44 UTC
sorry for leaving this review as I got busy with some other work now and this
review may take more time.

Comment 12 Ruben Kerkhof 2007-06-10 13:44:58 UTC
* RPM name is OK
* Source libcgi-1.0.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of libcgi-devel looks OK
* rpmlint of libcgi looks OK
* File list of libcgi looks OK

Please consider comment #10

Comment 13 Jose Pedro Oliveira 2007-06-26 03:38:51 UTC
ftp://perl.di.uminho.pt/pub/fedora/libcgi.spec
ftp://perl.di.uminho.pt/pub/fedora/libcgi-1.0-4.src.rpm

Changelog:
- The header files are now installed in %{_includedir}/%{name}
  (as recommend in comment #10).

Comment 14 Ruben Kerkhof 2007-06-26 06:10:26 UTC
approved.

Comment 15 Jose Pedro Oliveira 2007-06-26 12:56:52 UTC
New Package CVS Request
=======================
Package Name: libcgi
Short Description: CGI easy as C
Owners: jpo.pt
Branches: FC-6 F-7
InitialCC: 

Comment 16 Kevin Fenzi 2007-06-26 17:17:29 UTC
cvs done.

Comment 17 Ruben Kerkhof 2007-06-26 17:50:43 UTC
Hi Jose, are you willing to maintain this for EPEL as well?

I have libcgi running on a lot of servers at work, and could use a decent rpm ;-)

Comment 18 Jose Pedro Oliveira 2007-06-28 14:03:51 UTC
Package built for FC-6, F-7, and devel.
Already available in the F-7 and devel repos.

Comment 19 Jose Pedro Oliveira 2007-06-28 14:11:05 UTC
(In reply to comment #17)
> Hi Jose, are you willing to maintain this for EPEL as well?
> 
> I have libcgi running on a lot of servers at work, and could use a decent rpm ;-)

Ruben,

Don't you want to be a libcgi co-maintainer?

Right now I don't have any RHEL5/Centos5 system available.

jpo

Comment 20 Ruben Kerkhof 2007-06-28 17:36:40 UTC
Hi Jose,

I'd really like that. I only have RHEL4 (and 3, and 2 etc), no RHEL5 yet, but we'll figure that out.

Comment 21 Jose Pedro Oliveira 2007-06-28 20:37:34 UTC
Package Change Request
======================
Package Name: libcgi
Updated Fedora Owners: jpo.pt, ruben
New Branches: EL-4 EL-5


Comment 22 Jason Tibbitts 2007-07-01 01:15:07 UTC
CVS done.

Comment 23 Jose Pedro Oliveira 2007-07-01 02:11:00 UTC
Also built for EL-4 and EL-5.


Note You need to log in before you can comment on or make changes to this bug.