Bug 2221221 - Review Request: rust-regex-lite - Lightweight regex engine that optimizes for binary size and compilation time
Summary: Review Request: rust-regex-lite - Lightweight regex engine that optimizes for...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/regex-lite
Whiteboard:
Depends On: 2221224
Blocks: 2221189
TreeView+ depends on / blocked
 
Reported: 2023-07-07 14:52 UTC by Fabio Valentini
Modified: 2023-07-18 23:32 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-07-18 23:32:28 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-07-07 14:52:44 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-regex-lite.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-regex-lite-0.1.0-1.fc38.src.rpm

Description:
A lightweight regex engine that optimizes for binary size and
compilation time.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2023-07-07 14:56:48 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6149936
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2221221-rust-regex-lite/fedora-rawhide-x86_64/06149936-rust-regex-lite/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-07-11 19:08:18 UTC
All dependencies are now available in rawhide (in the f39-build-side-69806 side tag).

Comment 3 Michel Lind 2023-07-18 22:07:46 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fabio Valentini 2023-07-18 22:12:48 UTC
Thanks for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2023-07-18 22:13:19 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-regex-lite


Note You need to log in before you can comment on or make changes to this bug.