Bug 2221904 - Inconsistent icons for "Restart VM" messages
Summary: Inconsistent icons for "Restart VM" messages
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: User Experience
Version: 4.14.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: ---
Assignee: Tal Nisan
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-07-11 08:40 UTC by Avital Pinnick
Modified: 2023-07-24 10:09 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-07-20 09:58:42 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Warning icon for VM restart (19.01 KB, image/png)
2023-07-11 08:40 UTC, Avital Pinnick
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker CNV-30856 0 None None None 2023-07-11 08:41:17 UTC

Description Avital Pinnick 2023-07-11 08:40:00 UTC
Created attachment 1975107 [details]
Warning icon for VM restart

Many changes to VMs in the UI require the user to restart the VM.

Some of the "Restart VM" messages on the "Edit" modals have "Info" icons and some have "Warning" icons.

Comment 2 Hilda Stastna 2023-07-11 11:40:04 UTC
Hi Avital,

thanks for opening the BZ. And what do you suggest to change? What is the expected result? Thanks!

Comment 3 Avital Pinnick 2023-07-11 12:41:42 UTC
(In reply to Hilda Stastna from comment #2)
> Hi Avital,
> 
> thanks for opening the BZ. And what do you suggest to change? What is the
> expected result? Thanks!

I think your team can decide.

Comment 4 Yifat Menchik 2023-07-11 13:07:59 UTC
@apinnick I thought we agreed on "Restart the VirtualMachine to apply changes", is that correct?
Please see https://docs.google.com/document/d/1uYpwtXBP5pUfsLHM5EHr245BwJXQLf0KJWaewN9PwGk/edit

Comment 5 Guohua Ouyang 2023-07-12 07:47:03 UTC
Hi Avital,
What I saw is when the modal is opened, the message is an info, after make some changes in the modal, the info turns into a warning.
It looks like a good design to me as it could catch user attention by the changes, what do you think?

Comment 6 Yifat Menchik 2023-07-12 08:04:56 UTC
+1 to what @gouyang said. This behavior is by design.

Comment 7 Hilda Stastna 2023-07-12 10:05:36 UTC
Can someone explicitly provide the info what exactly is the expected result of this issue?
Where and what should we change? To which look? Thanks!

Comment 8 Yifat Menchik 2023-07-12 13:07:13 UTC
The only open issue is the text and @apinnick should say what should it be.

Comment 9 Avital Pinnick 2023-07-12 14:10:04 UTC
Are you saying that the modal changes from info to warning only if the user interacts with the modal (entering field, selecting checkbox)? I didn't realize that. 

In that case, this is not a bug. Feel free to close it.

Comment 10 Yifat Menchik 2023-07-12 14:15:03 UTC
@apinnick re comment # 9 - yes.
But please see comment # 4 and advise about the text.
Thanks.

Comment 11 Avital Pinnick 2023-07-20 09:58:27 UTC
The text was already decided in a google design doc. We do not need to repeat the discussion here.

Comment 12 Hilda Stastna 2023-07-20 10:32:47 UTC
It would be good to provide more specific info like which design doc and the specific text, when talking about design doc and some text. Thanks.

Comment 13 Yifat Menchik 2023-07-20 11:02:44 UTC
@hstastna this is not a bug.

The design doc that @apinnick refers to about the "Restart to apply changes..."  is this one https://docs.google.com/document/d/1uYpwtXBP5pUfsLHM5EHr245BwJXQLf0KJWaewN9PwGk/edit#heading=h.2habwhoaahkw
You can see that she recommended to change all the texts in the modals we have to be "Restart the VirtualMachine to apply changes". 
I suggest that you contact @phbailey because I think he is already working on this.
Thank you.

Comment 14 Hilda Stastna 2023-07-24 10:09:35 UTC
Thank you very much for provided details, Yifat.


Note You need to log in before you can comment on or make changes to this bug.