Bug 2226731 - Current koji client doesnt work with the rpmfusion instance: koji: GenericError: Invalid method: getKojiVersion
Summary: Current koji client doesnt work with the rpmfusion instance: koji: GenericErr...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: koji
Version: 37
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Mike McLean
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-07-26 11:08 UTC by Jaroslav Škarvada
Modified: 2024-01-22 17:26 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-10-23 11:51:55 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jaroslav Škarvada 2023-07-26 11:08:25 UTC
Current koji client doesn't work with rpmfusion koji instance.

Reproducible: Always

Steps to Reproduce:
1. koji -p koji-rpmfusion cancel $TASKID
or manually:
koji -s https://koji.rpmfusion.org/kojihub --cert=~/.rpmfusion.cert --authtype=ssl cancel $TASKID

Actual Results:  
2023-07-25 19:21:27,435 [ERROR] koji: GenericError: Invalid method: getKojiVersion



Expected Results:  
No error, task canceled.

It works OK with:
koji-1.21.0-2.fc30.noarch

Comment 1 Jaroslav Škarvada 2023-07-26 11:09:01 UTC
Reproduced with:
koji-1.33.0-1.fc37.noarch

Comment 2 Kevin Fenzi 2023-07-28 18:52:12 UTC
I'm not sure what version rpmfusion is running (it's old enough that it doesn't report that on the api page). 

I don't think koji claims interoperability between clients that are very far apart.

Adding kwizart here for comment on the rpmfusion instance, perhaps it could be upgraded?

If not, we probibly should move this upstream and see if there's anything to do to make it more compatible to older versions.

Comment 3 Nicolas Chauvet (kwizart) 2023-07-28 21:10:28 UTC
Right, I think that's a recent change that made any recent client start to fail with older el7 based koji.
We might backport the getKojiVersion method in the el7 branch or to fix the client to assume older koji if the getKojiversion cannot be found.

For now the workaround is to use el7 koji client for cancel tasks.

Comment 4 Nicolas Chauvet (kwizart) 2023-09-04 09:16:36 UTC
mike

Would it be possible to cut a new upstream release based on  1.21 branch ? with getKojiversion and other relevant fixes added ?
This would help us to work with newer koji client while still be el7 based.

Thanks in advance.

Comment 5 Nicolas Chauvet (kwizart) 2023-09-06 12:37:52 UTC
Fixed in the (newer) koji client side of things with https://pagure.io/koji/c/93a5ca5abe0e4d36b1e975f04978e9dfe430e37e?branch=master

Comment 6 Nicolas Chauvet (kwizart) 2023-10-23 11:51:55 UTC
Let's close this issue, will be fixed with koji-1.34.0, hopefully not too far.

Comment 7 Mike McLean 2024-01-22 17:26:09 UTC
We don't maintain older versions of Koji upstream, though we have in the past backported important cve fixes. When this has come up in the past, we drew the line at about 2 years (so at this point 1.21 would be past even that). We strongly recommend that all Koji instances stay up to date with upstream releases.

We do aim for the Koji cli client to be compatible with older hubs within reason, and we are open to addressing such issues. Please file upstream bugs for such cases.


Note You need to log in before you can comment on or make changes to this bug.