spec: https://suve.fedorapeople.org/review/cdecl-14.2-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-14.2-1/cdecl-14.2-1.fc38.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=104021474 Description: cdecl is a program that translates C language declarations into pseudo-English, like "int(*fn[2])(void*)" into "declare fn as an array 2 of pointer to function (pointer to void) returning integer". It can also do the inverse, generating C declarations from English phrases. Fedora Account System Username: suve
Copr build: https://copr.fedorainfracloud.org/coprs/build/6220374 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227277-cdecl/fedora-rawhide-x86_64/06220374-cdecl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to v14.3. spec: https://suve.fedorapeople.org/review/cdecl-14.3-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-14.3-1/cdecl-14.3-1.fc38.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=105613981
Created attachment 1986594 [details] The .spec file difference from Copr build 6220374 to 6362997
Copr build: https://copr.fedorainfracloud.org/coprs/build/6362997 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227277-cdecl/fedora-rawhide-x86_64/06362997-cdecl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to v14.4. spec: https://suve.fedorapeople.org/review/cdecl-14.4-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-14.4-1/cdecl-14.4-1.fc38.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=106274534
Updated to v15.0. spec: https://suve.fedorapeople.org/review/cdecl-15.0-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-15.0-1/cdecl-15.0-1.fc39.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=106998498
I am concerned about the relicensing. This is public domain.
I've brought the question up on the legal mailing list, and the answer there was that this should be OK to package. https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/QBYRCIMQDXAD2ZKUWKKYSTDB6T6GW2SO/ We can still open a ticket on the license-data GitLab, or mark this as blocked by FE-LEGAL, for further review.
Ok, sound reasonable. Since this is complicated, I think you should add the link and the entire text to the spec file. repost spec and srpm and I will go forward with the review.
Huh. I've updated the spec and then forgot to make a comment here. Anyway. Updated to v16.1. spec: https://suve.fedorapeople.org/review/cdecl-16.1-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-16.1-1/cdecl-16.1-1.fc39.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=112560612
Created attachment 2011904 [details] The .spec file difference from Copr build 6362997 to 6971775
Copr build: https://copr.fedorainfracloud.org/coprs/build/6971775 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227277-cdecl/fedora-rawhide-x86_64/06971775-cdecl/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GPL-3.0-or-later AND LGPL-2.1-or-later AND LicenseRef-Fedora-PublicDomain'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to v16.2.1. spec: https://suve.fedorapeople.org/review/cdecl-16.2.1-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-16.2.1-1/cdecl-16.2.1-1.fc39.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=113804640
Created attachment 2017961 [details] The .spec file difference from Copr build 6971775 to 7042156
Copr build: https://copr.fedorainfracloud.org/coprs/build/7042156 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227277-cdecl/fedora-rawhide-x86_64/07042156-cdecl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to v16.2.2. spec: https://suve.fedorapeople.org/review/cdecl-16.2.2-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-16.2.2-1/cdecl-16.2.2-1.fc39.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=114335183
Created attachment 2019788 [details] The .spec file difference from Copr build 7042156 to 7097401
Copr build: https://copr.fedorainfracloud.org/coprs/build/7097401 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227277-cdecl/fedora-rawhide-x86_64/07097401-cdecl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to v16.3. spec: https://suve.fedorapeople.org/review/cdecl-16.3-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-16.3-1/cdecl-16.3-1.fc40.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=117023308
Thanks for documenting the license discussion. Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/cdecl
FEDORA-2024-4ff196a896 (cdecl-16.3-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4ff196a896
FEDORA-2024-4ff196a896 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4ff196a896 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4ff196a896 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-4f37316d6a has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4f37316d6a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4f37316d6a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-3e6bb779ce has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3e6bb779ce` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3e6bb779ce See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-3e6bb779ce (cdecl-16.4.1-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.