Bug 2228426 - Review Request: git-credential-azure - Git credential helper for Azure Repos
Summary: Review Request: git-credential-azure - Git credential helper for Azure Repos
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pavel Solovev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-08-02 11:34 UTC by Mikel Olasagasti Uranga
Modified: 2023-08-02 13:57 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-08-02 13:57:05 UTC
Type: ---
Embargoed:
daron439: fedora-review+


Attachments (Terms of Use)

Description Mikel Olasagasti Uranga 2023-08-02 11:34:02 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/git-credential-azure.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/git-credential-azure-0.1.0-1.fc38.src.rpm
Description: A Git credential helper for Azure Repos.
Fedora Account System Username: mikelo2

Comment 1 Pavel Solovev 2023-08-02 13:13:27 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!

Comment 2 Pavel Solovev 2023-08-02 13:13:50 UTC
Could you please review https://bugzilla.redhat.com/show_bug.cgi?id=2227555, if you have time?

Comment 3 Fedora Admin user for bugzilla script actions 2023-08-02 13:45:15 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/git-credential-azure

Comment 4 Fedora Update System 2023-08-02 13:55:51 UTC
FEDORA-2023-2b9c570587 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-2b9c570587

Comment 5 Fedora Update System 2023-08-02 13:57:05 UTC
FEDORA-2023-2b9c570587 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.