This bug has been migrated to another issue tracking site. It has been closed here and may no longer be being monitored.

If you would like to get updates for this issue, or to participate in it, you may do so at Red Hat Issue Tracker .
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2229114 - sevctl ok should show correct SNP capability on Milan and Genoa
Summary: sevctl ok should show correct SNP capability on Milan and Genoa
Keywords:
Status: CLOSED MIGRATED
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: sevctl
Version: 9.3
Hardware: x86_64
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Tyler Fanelli
QA Contact: zixchen
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-08-04 08:43 UTC by zixchen
Modified: 2024-01-21 04:26 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-09-22 13:31:42 UTC
Type: ---
Target Upstream Version:
Embargoed:
pm-rhel: mirror+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker   RHEL-7121 0 None Migrated None 2023-09-22 13:31:38 UTC
Red Hat Issue Tracker RHELPLAN-164516 0 None None None 2023-08-04 08:45:53 UTC

Description zixchen 2023-08-04 08:43:35 UTC 
Description of problem:
sevctl ok returns 1 on SNP capable Milan and Genoa when host kernel doesn't support SNP

Version-Release number of selected component (if applicable):
sevctl-0.4.1-2.el9.x86_64

How reproducible:
100%

Steps to Reproduce:
1. on Milan /Genoa, host kernel not support SNP
# sevctl ok
[ PASS ] - AMD CPU
[ PASS ]   - Microcode support
[ PASS ]   - Secure Memory Encryption (SME)
[ PASS ]   - Secure Encrypted Virtualization (SEV)
[ PASS ]     - Encrypted State (SEV-ES)
[ FAIL ]     - Secure Nested Paging (SEV-SNP)
[ SKIP ]       - VM Permission Levels
[ SKIP ]         - Number of VMPLs
[ PASS ]     - Physical address bit reduction: 6
[ PASS ]     - C-bit location: 51
[ PASS ]     - Number of encrypted guests supported simultaneously: 1006
[ PASS ]     - Minimum ASID value for SEV-enabled, SEV-ES disabled guest: 10
[ PASS ]     - SEV enabled in KVM: enabled
[ PASS ]     - SEV-ES enabled in KVM: enabled
[ PASS ]     - Reading /dev/sev: /dev/sev readable
[ PASS ]     - Writing /dev/sev: /dev/sev writable
[ PASS ]   - Page flush MSR: DISABLED
[ PASS ] - KVM supported: API version: 12
[ PASS ] - Memlock resource limit: Soft: 8388608 | Hard: 8388608
Error: One or more tests in sevctl-ok reported a failure


Expected results:
sevctl return 0 on SNP capability
Additional info:
Comment 1 Tyler Fanelli 2023-08-04 16:55:33 UTC 
In QA tests for 9.3 release, we found a "bug" in the way Genoa encodes SEV-SNP support. Not really a bug, but the SEV-SNP CPUID encoding is not the same as Naples, Rome, or Milan. Therefore, if Genoa is detected, we need to check SEV-SNP in "Genoa's way".
Comment 2 Tyler Fanelli 2023-08-10 17:21:35 UTC 
Upon further investigation, I don't think this is a bug. I missed a part in the description:

sevctl ok returns 1 on SNP capable Milan and Genoa when host kernel doesn't support SNP
                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

In historical sevctl instances, ONLY the processor capabilities were checked for SEV-SNP support. In our latest release, we also check /dev/cpu/0/msr to check if SEV-SNP is enabled by the kernel, as well as in the CPU. Before, sevctl checked for processor capability to run SEV-SNP. Now, sevctl checks the overall system (firmware, kernel, etc). I think the MSR check is where sevctl is failing on Genoa.

https://github.com/virtee/sevctl/blob/c41c9172be013d6f10b9e1d7286fcb021805d5a5/src/ok.rs#L279-L289

Zixi, can I have SSH access to the Genoa machine to test this?
Comment 3 zixchen 2023-08-17 02:16:17 UTC 
(In reply to Tyler Fanelli from comment #2)
> Upon further investigation, I don't think this is a bug. I missed a part in
> the description:
> 
> sevctl ok returns 1 on SNP capable Milan and Genoa when host kernel doesn't
> support SNP
>                                                        
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> In historical sevctl instances, ONLY the processor capabilities were checked
> for SEV-SNP support. In our latest release, we also check /dev/cpu/0/msr to
> check if SEV-SNP is enabled by the kernel, as well as in the CPU. Before,
> sevctl checked for processor capability to run SEV-SNP. Now, sevctl checks
> the overall system (firmware, kernel, etc). I think the MSR check is where
> sevctl is failing on Genoa.
> 
> https://github.com/virtee/sevctl/blob/
> c41c9172be013d6f10b9e1d7286fcb021805d5a5/src/ok.rs#L279-L289
> 
> Zixi, can I have SSH access to the Genoa machine to test this?

Sure, I just came back from PTO, you can have a test on my testing Genoa. 

By the way, could you please also check if this bug https://bugzilla.redhat.com/show_bug.cgi?id=2214839 affects sevctl ok info on Milan: [ PASS ]     - Physical address bit reduction: 5 and Genoa [ PASS ]     - Physical address bit reduction: 6?
Comment 4 RHEL Program Management 2023-09-22 13:30:31 UTC 
Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.
Comment 5 RHEL Program Management 2023-09-22 13:31:42 UTC 
This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.
Comment 6 Red Hat Bugzilla 2024-01-21 04:26:04 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days
Note You need to log in before you can comment on or make changes to this bug.